From patchwork Thu May 13 16:38:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12256041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC99C433ED for ; Thu, 13 May 2021 17:03:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D66D61354 for ; Thu, 13 May 2021 17:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D66D61354 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEke-0008GL-Cv for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 13:03:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENE-0002fj-0H for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhENC-00010c-9n for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=fVQDnjQ70ArC9PNqIIqFpPXf+2lRhZ8TUW1yuBySJHlIjN375yUqY2nGCoIMYZ31BOFmrd Id96KG23lQa5Q1RzLIteJHi+X2l80NP76wgN3x1MGyLEhl+2PamNIiPaF2FcPCz5QQS9G3 laDIyYnX6brw9WG1beHWQ7XlruHY/gI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-Y8oR7OqBOR-71WTKRZYJ4w-1; Thu, 13 May 2021 12:39:40 -0400 X-MC-Unique: Y8oR7OqBOR-71WTKRZYJ4w-1 Received: by mail-ed1-f70.google.com with SMTP id k10-20020a50cb8a0000b0290387e0173bf7so15044021edi.8 for ; Thu, 13 May 2021 09:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=GIX80vJLg/ZaJQPYxamfHXTbYe7qk6pI+bUm1V3f8PviYWlD+V8tyP+pT0Npl5AM8o V50ha6bIb9WGyA0EPvjMpftKmugg6m96mPlf4n/QRyHRralHuWee5ZhjjF1mASK/dCLb eHWih4CiXXjZAVtGsfkqxwFkRJI89ZPekBF0K8EyeqY4nUl+7XLE/eP0N7wabzIvnKRN xrVuhLC+BdeZrAQe4P9SQexwwzDk51LljeJswCLppiHDhFx6DevOPLWc9hzVURE0MsO5 tXhDtjBG0t8kxJtMYU511m8Du3OQYPnpsL9lZf+eLTCOgmE/ruhnfB+TCV8cMr5cA/Ax NUQw== X-Gm-Message-State: AOAM530cEAEADUYfPUy1HB5wGpxce02dd+LwD4lVD135AKEkmqKkcvz6 snobbXVFB2biJg5bVFdVXBmFjq6Jg+O8Ks1MNAtreY4InpNWR36wiOEyueKQLhvlSVKEOpNc6lP Q2WgCmovlY10HemmDLEpQC84bRkE/Giu4tDu1GOY/l+kgJT0OZa1yOXQLECl8TI7h X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117606edq.310.1620923978896; Thu, 13 May 2021 09:39:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAzVgm8Qwn9FiXpF/yuznqTA1YfSKUmYrD/MywIqRiF1fT01onNfI3Q+vOESyc3JUACn3t3A== X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117585edq.310.1620923978688; Thu, 13 May 2021 09:39:38 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id i6sm2713664eds.83.2021.05.13.09.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:38 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 08/10] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Date: Thu, 13 May 2021 18:38:56 +0200 Message-Id: <20210513163858.3928976-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kurz , Amit Singh Tomar , "open list:PowerPC TCG CPUs" , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Andrew Randrianasulu , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=y config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson Reviewed-by: Bin Meng --- Cc: Amit Singh Tomar Cc: Andrew Randrianasulu --- default-configs/devices/ppc-softmmu.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devices/ppc-softmmu.mak index c2d41198cde..5a7f99d1e45 100644 --- a/default-configs/devices/ppc-softmmu.mak +++ b/default-configs/devices/ppc-softmmu.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu # For embedded PPCs: -CONFIG_DS1338=y CONFIG_E500=y CONFIG_PPC405=y CONFIG_PPC440=y diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 66e0b15d9ef..2e4c56eb770 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -128,6 +128,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 config VIRTEX bool