Message ID | 20210519152541.30625-1-mwilck@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | qemu-binfmt-conf.sh: fix -F option | expand |
Patchew URL: https://patchew.org/QEMU/20210519152541.30625-1-mwilck@suse.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210519152541.30625-1-mwilck@suse.com Subject: [PATCH] qemu-binfmt-conf.sh: fix -F option === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210519152541.30625-1-mwilck@suse.com -> patchew/20210519152541.30625-1-mwilck@suse.com Switched to a new branch 'test' d41a07b qemu-binfmt-conf.sh: fix -F option === OUTPUT BEGIN === ERROR: line over 90 characters #25: FILE: scripts/qemu-binfmt-conf.sh:343: +options=$(getopt -o ds:Q:S:e:hc:p:g:F: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@") total: 1 errors, 0 warnings, 8 lines checked Commit d41a07b4a4df (qemu-binfmt-conf.sh: fix -F option) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210519152541.30625-1-mwilck@suse.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index fb504a4..29ea33b 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt-conf.sh @@ -338,7 +338,7 @@ PERSISTENT=no PRESERVE_ARG0=no QEMU_SUFFIX="" -options=$(getopt -o ds:Q:S:e:hc:p:g: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@") +options=$(getopt -o ds:Q:S:e:hc:p:g:F: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@") eval set -- "$options" while true ; do