| Message ID | 20210519200942.2223292-4-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/arm/Kconfig: Fix issues with USB_CHIPIDEA / IMX_USBPHY symbols | expand |
On Wed, 19 May 2021 at 21:10, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX > USB Phy support") and had the FSL_IMX6 machine select it, however > this machine did not use the IMX_USBPHY until commit 49cd55789bb > ("hw/arm/fsl-imx6: Wire up USB controllers"). Commit 17372bd812d > ("hw/arm/fsl-imx6ul: Wire up USB controllers") added the similar > dependency but forgot to select the Kconfig symbol. Do it now to > solve when building using --without-default-devices: > > $ qemu-system-arm -M mcimx6ul-evk > qemu-system-arm: missing object type 'imx.usbphy' > Aborted (core dumped) > > Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/arm/Kconfig | 1 + Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 838737656f7..3c3e2e94086 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -465,6 +465,7 @@ config FSL_IMX6UL select SDHCI select UNIMP select USB_CHIPIDEA + select IMX_USBPHY config MICROBIT bool
We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX USB Phy support") and had the FSL_IMX6 machine select it, however this machine did not use the IMX_USBPHY until commit 49cd55789bb ("hw/arm/fsl-imx6: Wire up USB controllers"). Commit 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") added the similar dependency but forgot to select the Kconfig symbol. Do it now to solve when building using --without-default-devices: $ qemu-system-arm -M mcimx6ul-evk qemu-system-arm: missing object type 'imx.usbphy' Aborted (core dumped) Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)