| Message ID | 20210521201759.85475-9-bruno.larsen@eldorado.org.br (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/ppc: add support to disable-tcg | expand |
On Fri, May 21, 2021 at 05:17:58PM -0300, Bruno Larsen (billionai) wrote: > Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes > were created to make cpu_init.c have a few less ifdefs, since they are > not needed. coftmmu_resize_hpt_* have to be created because the compiler > can't automatically know they aren't used, but they should never be > reached. > > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > --- > target/ppc/meson.build | 4 ++++ > target/ppc/tcg-stub.c | 25 +++++++++++++++++++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 target/ppc/tcg-stub.c > > diff --git a/target/ppc/meson.build b/target/ppc/meson.build > index d1aa7d5d39..848e625302 100644 > --- a/target/ppc/meson.build > +++ b/target/ppc/meson.build > @@ -28,6 +28,10 @@ ppc_softmmu_ss.add(files( > 'mmu_helper.c', > 'monitor.c', > )) > +ppc_softmmu_ss.add(when: 'CONFIG_TCG', if_false: files( > + 'tcg-stub.c' > +)) > + > ppc_softmmu_ss.add(when: 'TARGET_PPC64', if_true: files( > 'compat.c', > 'mmu-book3s-v3.c', > diff --git a/target/ppc/tcg-stub.c b/target/ppc/tcg-stub.c > new file mode 100644 > index 0000000000..6d99834274 > --- /dev/null > +++ b/target/ppc/tcg-stub.c New file needs a copyright banner. > @@ -0,0 +1,25 @@ > +#include "qemu/osdep.h" > +#include "cpu.h" > +#include "internal.h" > +#include "hw/ppc/spapr.h" > + > +void create_ppc_opcodes(PowerPCCPU *cpu, Error **errp) > +{} I believe style dictates this be { } rather than {} > + > +void destroy_ppc_opcodes(PowerPCCPU *cpu) > +{} > + > +target_ulong softmmu_resize_hpt_prepare(PowerPCCPU *cpu, > + SpaprMachineState *spapr, > + target_ulong shift) > +{ > + g_assert_not_reached(); > +} > + > +target_ulong softmmu_resize_hpt_commit(PowerPCCPU *cpu, > + SpaprMachineState *spapr, > + target_ulong flags, > + target_ulong shift) > +{ > + g_assert_not_reached(); > +}
On 24/05/2021 00:02, David Gibson wrote: > On Fri, May 21, 2021 at 05:17:58PM -0300, Bruno Larsen (billionai) wrote: >> Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes >> were created to make cpu_init.c have a few less ifdefs, since they are >> not needed. coftmmu_resize_hpt_* have to be created because the compiler >> can't automatically know they aren't used, but they should never be >> reached. >> >> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> >> --- >> target/ppc/meson.build | 4 ++++ >> target/ppc/tcg-stub.c | 25 +++++++++++++++++++++++++ >> 2 files changed, 29 insertions(+) >> create mode 100644 target/ppc/tcg-stub.c >> >> diff --git a/target/ppc/meson.build b/target/ppc/meson.build >> index d1aa7d5d39..848e625302 100644 >> --- a/target/ppc/meson.build >> +++ b/target/ppc/meson.build >> @@ -28,6 +28,10 @@ ppc_softmmu_ss.add(files( >> 'mmu_helper.c', >> 'monitor.c', >> )) >> +ppc_softmmu_ss.add(when: 'CONFIG_TCG', if_false: files( >> + 'tcg-stub.c' >> +)) >> + >> ppc_softmmu_ss.add(when: 'TARGET_PPC64', if_true: files( >> 'compat.c', >> 'mmu-book3s-v3.c', >> diff --git a/target/ppc/tcg-stub.c b/target/ppc/tcg-stub.c >> new file mode 100644 >> index 0000000000..6d99834274 >> --- /dev/null >> +++ b/target/ppc/tcg-stub.c > New file needs a copyright banner. Doh. how can I always forget this? >> @@ -0,0 +1,25 @@ >> +#include "qemu/osdep.h" >> +#include "cpu.h" >> +#include "internal.h" >> +#include "hw/ppc/spapr.h" >> + >> +void create_ppc_opcodes(PowerPCCPU *cpu, Error **errp) >> +{} > I believe style dictates this be > { > } > > rather than > {} > huh, on it. Should we try and add this to the checkpatch script? no one complained about it anywhere...
diff --git a/target/ppc/meson.build b/target/ppc/meson.build index d1aa7d5d39..848e625302 100644 --- a/target/ppc/meson.build +++ b/target/ppc/meson.build @@ -28,6 +28,10 @@ ppc_softmmu_ss.add(files( 'mmu_helper.c', 'monitor.c', )) +ppc_softmmu_ss.add(when: 'CONFIG_TCG', if_false: files( + 'tcg-stub.c' +)) + ppc_softmmu_ss.add(when: 'TARGET_PPC64', if_true: files( 'compat.c', 'mmu-book3s-v3.c', diff --git a/target/ppc/tcg-stub.c b/target/ppc/tcg-stub.c new file mode 100644 index 0000000000..6d99834274 --- /dev/null +++ b/target/ppc/tcg-stub.c @@ -0,0 +1,25 @@ +#include "qemu/osdep.h" +#include "cpu.h" +#include "internal.h" +#include "hw/ppc/spapr.h" + +void create_ppc_opcodes(PowerPCCPU *cpu, Error **errp) +{} + +void destroy_ppc_opcodes(PowerPCCPU *cpu) +{} + +target_ulong softmmu_resize_hpt_prepare(PowerPCCPU *cpu, + SpaprMachineState *spapr, + target_ulong shift) +{ + g_assert_not_reached(); +} + +target_ulong softmmu_resize_hpt_commit(PowerPCCPU *cpu, + SpaprMachineState *spapr, + target_ulong flags, + target_ulong shift) +{ + g_assert_not_reached(); +}
Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes were created to make cpu_init.c have a few less ifdefs, since they are not needed. coftmmu_resize_hpt_* have to be created because the compiler can't automatically know they aren't used, but they should never be reached. Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> --- target/ppc/meson.build | 4 ++++ target/ppc/tcg-stub.c | 25 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 target/ppc/tcg-stub.c