diff mbox series

[3/3] meson: List modules built in summary

Message ID 20210525104648.4060904-4-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series meson: Minor improvements | expand

Commit Message

Philippe Mathieu-Daudé May 25, 2021, 10:46 a.m. UTC
Instead of guessing the modules built, list them. Example:

  Modules
    audio                        : spice
    block                        : curl dmg-bz2 gluster iscsi rbd ssh
    chardev                      : spice
    hw-display                   :
    hw-s390x                     : virtio-gpu-ccw
    hw-usb                       : redirect smartcard
    ui                           : egl-headless gtk opengl spice-app spice-core

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 meson.build | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Philippe Mathieu-Daudé May 26, 2021, 7:29 a.m. UTC | #1
On 5/25/21 12:46 PM, Philippe Mathieu-Daudé wrote:
> Instead of guessing the modules built, list them. Example:
> 
>   Modules
>     audio                        : spice
>     block                        : curl dmg-bz2 gluster iscsi rbd ssh
>     chardev                      : spice
>     hw-display                   :
>     hw-s390x                     : virtio-gpu-ccw
>     hw-usb                       : redirect smartcard
>     ui                           : egl-headless gtk opengl spice-app spice-core
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  meson.build | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 5ca1bd36292..54b97ace207 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2738,6 +2738,17 @@
>  summary_info += {'FUSE lseek':        fuse_lseek.found()}
>  summary(summary_info, bool_yn: true, section: 'Dependencies')
>  
> +# Modules
> +summary_info = {}
> +foreach d, list : modules
> +  k = []
> +    foreach m, _ : list
> +      k += [m]

Clearer renaming k -> mods, m -> mod and d -> k.

> +    endforeach
> +  summary_info += {d: ' '.join(k)}
> +endforeach
> +summary(summary_info, bool_yn: true, section: 'Modules')
> +
>  if not supported_cpus.contains(cpu)
>    message()
>    warning('SUPPORT FOR THIS HOST CPU WILL GO AWAY IN FUTURE RELEASES!')
>
Paolo Bonzini May 27, 2021, 8:08 p.m. UTC | #2
On 25/05/21 12:46, Philippe Mathieu-Daudé wrote:
> +  k = []
> +    foreach m, _ : list
> +      k += [m]
> +    endforeach
> +  summary_info += {d: ' '.join(k)}

Perhaps:

foreach dir, list : modules
   if list.keys().length() > 0
     summary_info += {dir: ' '.join(list.keys())}
   endif
endforeach

Paolo

> +endforeach
> +summary(summary_info, bool_yn: true, section: 'Modules')
> +
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 5ca1bd36292..54b97ace207 100644
--- a/meson.build
+++ b/meson.build
@@ -2738,6 +2738,17 @@ 
 summary_info += {'FUSE lseek':        fuse_lseek.found()}
 summary(summary_info, bool_yn: true, section: 'Dependencies')
 
+# Modules
+summary_info = {}
+foreach d, list : modules
+  k = []
+    foreach m, _ : list
+      k += [m]
+    endforeach
+  summary_info += {d: ' '.join(k)}
+endforeach
+summary(summary_info, bool_yn: true, section: 'Modules')
+
 if not supported_cpus.contains(cpu)
   message()
   warning('SUPPORT FOR THIS HOST CPU WILL GO AWAY IN FUTURE RELEASES!')