mbox

[PULL,0/7] testing, gdbstub and plugin updates

Message ID 20210525112431.22005-1-alex.bennee@linaro.org (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521-1

Message

Alex Bennée May 25, 2021, 11:24 a.m. UTC
The gprof/gcov passed on retry. I'll continue to look at it but didn't want
to hold up the PR because of it. - Alex

The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049:

  Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-24 15:48:08 +0100)

are available in the Git repository at:

  https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521-1

for you to fetch changes up to bb84bcf61495e9c2907b0659a60beacd2e92e34e:

  plugins/syscall: Added a table-like summary output (2021-05-25 09:24:21 +0100)

----------------------------------------------------------------
Testing, gdbstub and plugin updates

  - ensure gitlab references master registry
  - add special rule for hexagon image
  - clean-up gdbstub's argument handling
  - fix replay HMP commands to accept long icount
  - minor re-factor of gdbstub replay handling
  - update syscall plugin to be more useful

----------------------------------------------------------------
Alex Bennée (5):
      gitlab: explicitly reference the upstream registry
      gitlab: add special rule for the hexagon container
      gdbstub: Replace GdbCmdContext with plain g_array()
      hmp-commands: expand type of icount to "l" in replay commands
      gdbstub: tidy away reverse debugging check into function

Mahmoud Mandour (1):
      plugins/syscall: Added a table-like summary output

Philippe Mathieu-Daudé (1):
      gdbstub: Constify GdbCmdParseEntry

 gdbstub.c                   | 343 ++++++++++++++++++++++----------------------
 tests/plugin/syscall.c      |  98 ++++++++++++-
 .gitlab-ci.d/containers.yml |  30 +++-
 .gitlab-ci.yml              |   2 +
 hmp-commands.hx             |   4 +-
 5 files changed, 294 insertions(+), 183 deletions(-)

Comments

Philippe Mathieu-Daudé May 25, 2021, 12:28 p.m. UTC | #1
On 5/25/21 1:24 PM, Alex Bennée wrote:
> The gprof/gcov passed on retry. I'll continue to look at it but didn't want
> to hold up the PR because of it. - Alex
> 
> The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049:
> 
>   Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-24 15:48:08 +0100)
> 
> are available in the Git repository at:
> 
>   https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521-1
> 
> for you to fetch changes up to bb84bcf61495e9c2907b0659a60beacd2e92e34e:
> 
>   plugins/syscall: Added a table-like summary output (2021-05-25 09:24:21 +0100)
> 
> ----------------------------------------------------------------
> Testing, gdbstub and plugin updates
> 
>   - ensure gitlab references master registry
>   - add special rule for hexagon image
>   - clean-up gdbstub's argument handling
>   - fix replay HMP commands to accept long icount
>   - minor re-factor of gdbstub replay handling
>   - update syscall plugin to be more useful
> 
> ----------------------------------------------------------------
> Alex Bennée (5):
>       gitlab: explicitly reference the upstream registry
>       gitlab: add special rule for the hexagon container

FYI there is still an issue with this patch:

  'build-user-hexagon' job needs 'hexagon-cross-container' job,
  but it was not added to the pipeline
Alex Bennée May 25, 2021, 3:05 p.m. UTC | #2
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 5/25/21 1:24 PM, Alex Bennée wrote:
>> The gprof/gcov passed on retry. I'll continue to look at it but didn't want
>> to hold up the PR because of it. - Alex
>> 
>> The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049:
>> 
>>   Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-24 15:48:08 +0100)
>> 
>> are available in the Git repository at:
>> 
>>   https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521-1
>> 
>> for you to fetch changes up to bb84bcf61495e9c2907b0659a60beacd2e92e34e:
>> 
>>   plugins/syscall: Added a table-like summary output (2021-05-25 09:24:21 +0100)
>> 
>> ----------------------------------------------------------------
>> Testing, gdbstub and plugin updates
>> 
>>   - ensure gitlab references master registry
>>   - add special rule for hexagon image
>>   - clean-up gdbstub's argument handling
>>   - fix replay HMP commands to accept long icount
>>   - minor re-factor of gdbstub replay handling
>>   - update syscall plugin to be more useful
>> 
>> ----------------------------------------------------------------
>> Alex Bennée (5):
>>       gitlab: explicitly reference the upstream registry
>>       gitlab: add special rule for the hexagon container
>
> FYI there is still an issue with this patch:
>
>   'build-user-hexagon' job needs 'hexagon-cross-container' job,
>   but it was not added to the pipeline

It doesn't need to be added to the pipeline for the main project as it's
always there. The change was to ensure users building their pipelines
have a copy in their personal registry.
Peter Maydell May 25, 2021, 3:15 p.m. UTC | #3
On Tue, 25 May 2021 at 12:24, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The gprof/gcov passed on retry. I'll continue to look at it but didn't want
> to hold up the PR because of it. - Alex
>
> The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049:
>
>   Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-24 15:48:08 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521-1
>
> for you to fetch changes up to bb84bcf61495e9c2907b0659a60beacd2e92e34e:
>
>   plugins/syscall: Added a table-like summary output (2021-05-25 09:24:21 +0100)
>
> ----------------------------------------------------------------
> Testing, gdbstub and plugin updates
>
>   - ensure gitlab references master registry
>   - add special rule for hexagon image
>   - clean-up gdbstub's argument handling
>   - fix replay HMP commands to accept long icount
>   - minor re-factor of gdbstub replay handling
>   - update syscall plugin to be more useful
>
> ----------------------------------------------------------------

This fails gitlab CI with a "yaml invalid" error:

https://gitlab.com/qemu-project/qemu/-/pipelines/309137207

-- PMM