| Message ID | 20210526202104.127910-5-bruno.larsen@eldorado.org.br (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | stop collection of instruction usage statistics | expand |
On 5/26/21 1:21 PM, Bruno Larsen (billionai) wrote: > Since ppc was the last architecture to collect these statistics and > it is currently phasing this collection out, the command that would query > this information is being removed. > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > --- > hmp-commands-info.hx | 13 ------------- > monitor/misc.c | 11 ----------- > 2 files changed, 24 deletions(-) Cc: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ab0c7aa5ee..b2347a6aea 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -500,19 +500,6 @@ SRST > Show the current VM UUID. > ERST > > - { > - .name = "cpustats", > - .args_type = "", > - .params = "", > - .help = "show CPU statistics", > - .cmd = hmp_info_cpustats, > - }, > - > -SRST > - ``info cpustats`` > - Show CPU statistics. > -ERST > - > #if defined(CONFIG_SLIRP) > { > .name = "usernet", > diff --git a/monitor/misc.c b/monitor/misc.c > index f3a393ea59..1539e18557 100644 > --- a/monitor/misc.c > +++ b/monitor/misc.c > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > } > } > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > -{ > - CPUState *cs = mon_get_cpu(mon); > - > - if (!cs) { > - monitor_printf(mon, "No CPU available\n"); > - return; > - } > - cpu_dump_statistics(cs, 0); > -} > - > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > { > const char *name = qdict_get_try_str(qdict, "name"); >
From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > Since ppc was the last architecture to collect these statistics and it is currently > phasing this collection out, the command that would query this information is > being removed. > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > --- > hmp-commands-info.hx | 13 ------------- > monitor/misc.c | 11 ----------- > 2 files changed, 24 deletions(-) Reviewed-by: Luis Pires <luis.pires@eldorado.org.br> -- Luis Pires Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br> Departamento de Computação Embarcada Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
On Wed, May 26, 2021 at 02:28:48PM -0700, Richard Henderson wrote: > On 5/26/21 1:21 PM, Bruno Larsen (billionai) wrote: > > Since ppc was the last architecture to collect these statistics and > > it is currently phasing this collection out, the command that would query > > this information is being removed. > > > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > > --- > > hmp-commands-info.hx | 13 ------------- > > monitor/misc.c | 11 ----------- > > 2 files changed, 24 deletions(-) > > Cc: Dr. David Alan Gilbert <dgilbert@redhat.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Applied to ppc-for-6.1. I'm staging this in my tree, but an Ack from Dave Gilbert would be appreciated. > > > r~ > > > > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > > index ab0c7aa5ee..b2347a6aea 100644 > > --- a/hmp-commands-info.hx > > +++ b/hmp-commands-info.hx > > @@ -500,19 +500,6 @@ SRST > > Show the current VM UUID. > > ERST > > - { > > - .name = "cpustats", > > - .args_type = "", > > - .params = "", > > - .help = "show CPU statistics", > > - .cmd = hmp_info_cpustats, > > - }, > > - > > -SRST > > - ``info cpustats`` > > - Show CPU statistics. > > -ERST > > - > > #if defined(CONFIG_SLIRP) > > { > > .name = "usernet", > > diff --git a/monitor/misc.c b/monitor/misc.c > > index f3a393ea59..1539e18557 100644 > > --- a/monitor/misc.c > > +++ b/monitor/misc.c > > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > > } > > } > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > > -{ > > - CPUState *cs = mon_get_cpu(mon); > > - > > - if (!cs) { > > - monitor_printf(mon, "No CPU available\n"); > > - return; > > - } > > - cpu_dump_statistics(cs, 0); > > -} > > - > > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > > { > > const char *name = qdict_get_try_str(qdict, "name"); > > > >
On Wed, 26 May 2021 17:21:03 -0300 "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > Since ppc was the last architecture to collect these statistics and > it is currently phasing this collection out, the command that would query > this information is being removed. > So this is removing an obviously user visible feature. This should be mentioned in docs/system/removed-features.rst... but, wait, I don't see anything for it in docs/system/deprecated.rst. This is dropping a feature without following the usual deprecation policy, i.e. marking the feature as deprecated and only remove it 2 QEMU versions later. Any justification for that ? David, Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab but the commit title appears to be broken: '65;6401;1cmonitor: removed cpustats command https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > --- > hmp-commands-info.hx | 13 ------------- > monitor/misc.c | 11 ----------- > 2 files changed, 24 deletions(-) > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ab0c7aa5ee..b2347a6aea 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -500,19 +500,6 @@ SRST > Show the current VM UUID. > ERST > > - { > - .name = "cpustats", > - .args_type = "", > - .params = "", > - .help = "show CPU statistics", > - .cmd = hmp_info_cpustats, > - }, > - > -SRST > - ``info cpustats`` > - Show CPU statistics. > -ERST > - > #if defined(CONFIG_SLIRP) > { > .name = "usernet", > diff --git a/monitor/misc.c b/monitor/misc.c > index f3a393ea59..1539e18557 100644 > --- a/monitor/misc.c > +++ b/monitor/misc.c > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > } > } > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > -{ > - CPUState *cs = mon_get_cpu(mon); > - > - if (!cs) { > - monitor_printf(mon, "No CPU available\n"); > - return; > - } > - cpu_dump_statistics(cs, 0); > -} > - > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > { > const char *name = qdict_get_try_str(qdict, "name");
* Bruno Larsen (billionai) (bruno.larsen@eldorado.org.br) wrote: > Since ppc was the last architecture to collect these statistics and > it is currently phasing this collection out, the command that would query > this information is being removed. > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > hmp-commands-info.hx | 13 ------------- > monitor/misc.c | 11 ----------- > 2 files changed, 24 deletions(-) > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ab0c7aa5ee..b2347a6aea 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -500,19 +500,6 @@ SRST > Show the current VM UUID. > ERST > > - { > - .name = "cpustats", > - .args_type = "", > - .params = "", > - .help = "show CPU statistics", > - .cmd = hmp_info_cpustats, > - }, > - > -SRST > - ``info cpustats`` > - Show CPU statistics. > -ERST > - > #if defined(CONFIG_SLIRP) > { > .name = "usernet", > diff --git a/monitor/misc.c b/monitor/misc.c > index f3a393ea59..1539e18557 100644 > --- a/monitor/misc.c > +++ b/monitor/misc.c > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > } > } > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > -{ > - CPUState *cs = mon_get_cpu(mon); > - > - if (!cs) { > - monitor_printf(mon, "No CPU available\n"); > - return; > - } > - cpu_dump_statistics(cs, 0); > -} > - > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > { > const char *name = qdict_get_try_str(qdict, "name"); > -- > 2.17.1 >
* Greg Kurz (groug@kaod.org) wrote: > On Wed, 26 May 2021 17:21:03 -0300 > "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > > > Since ppc was the last architecture to collect these statistics and > > it is currently phasing this collection out, the command that would query > > this information is being removed. > > > > So this is removing an obviously user visible feature. This should be > mentioned in docs/system/removed-features.rst... but, wait, I don't > see anything for it in docs/system/deprecated.rst. This is dropping > a feature without following the usual deprecation policy, i.e. > marking the feature as deprecated and only remove it 2 QEMU versions > later. Any justification for that ? As long as the command really isn't useful any more, I wouldn't object to that from an HMP point of view. Dave > David, > > Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab > but the commit title appears to be broken: > > '65;6401;1cmonitor: removed cpustats command > > https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 > > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > > --- > > hmp-commands-info.hx | 13 ------------- > > monitor/misc.c | 11 ----------- > > 2 files changed, 24 deletions(-) > > > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > > index ab0c7aa5ee..b2347a6aea 100644 > > --- a/hmp-commands-info.hx > > +++ b/hmp-commands-info.hx > > @@ -500,19 +500,6 @@ SRST > > Show the current VM UUID. > > ERST > > > > - { > > - .name = "cpustats", > > - .args_type = "", > > - .params = "", > > - .help = "show CPU statistics", > > - .cmd = hmp_info_cpustats, > > - }, > > - > > -SRST > > - ``info cpustats`` > > - Show CPU statistics. > > -ERST > > - > > #if defined(CONFIG_SLIRP) > > { > > .name = "usernet", > > diff --git a/monitor/misc.c b/monitor/misc.c > > index f3a393ea59..1539e18557 100644 > > --- a/monitor/misc.c > > +++ b/monitor/misc.c > > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > > } > > } > > > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > > -{ > > - CPUState *cs = mon_get_cpu(mon); > > - > > - if (!cs) { > > - monitor_printf(mon, "No CPU available\n"); > > - return; > > - } > > - cpu_dump_statistics(cs, 0); > > -} > > - > > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > > { > > const char *name = qdict_get_try_str(qdict, "name"); >
On Thu, 27 May 2021 09:09:55 +0100 "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote: > * Greg Kurz (groug@kaod.org) wrote: > > On Wed, 26 May 2021 17:21:03 -0300 > > "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > > > > > Since ppc was the last architecture to collect these statistics and > > > it is currently phasing this collection out, the command that would query > > > this information is being removed. > > > > > > > So this is removing an obviously user visible feature. This should be > > mentioned in docs/system/removed-features.rst... but, wait, I don't > > see anything for it in docs/system/deprecated.rst. This is dropping > > a feature without following the usual deprecation policy, i.e. > > marking the feature as deprecated and only remove it 2 QEMU versions > > later. Any justification for that ? > > As long as the command really isn't useful any more, I wouldn't object > to that from an HMP point of view. > Ok then this should be documented in docs/system/removed-features.rst at least. > Dave > > > David, > > > > Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab > > but the commit title appears to be broken: > > > > '65;6401;1cmonitor: removed cpustats command > > > > https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 > > > > > Suggested-by: Richard Henderson <richard.henderson@linaro.org> > > > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > > > --- > > > hmp-commands-info.hx | 13 ------------- > > > monitor/misc.c | 11 ----------- > > > 2 files changed, 24 deletions(-) > > > > > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > > > index ab0c7aa5ee..b2347a6aea 100644 > > > --- a/hmp-commands-info.hx > > > +++ b/hmp-commands-info.hx > > > @@ -500,19 +500,6 @@ SRST > > > Show the current VM UUID. > > > ERST > > > > > > - { > > > - .name = "cpustats", > > > - .args_type = "", > > > - .params = "", > > > - .help = "show CPU statistics", > > > - .cmd = hmp_info_cpustats, > > > - }, > > > - > > > -SRST > > > - ``info cpustats`` > > > - Show CPU statistics. > > > -ERST > > > - > > > #if defined(CONFIG_SLIRP) > > > { > > > .name = "usernet", > > > diff --git a/monitor/misc.c b/monitor/misc.c > > > index f3a393ea59..1539e18557 100644 > > > --- a/monitor/misc.c > > > +++ b/monitor/misc.c > > > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > > > } > > > } > > > > > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > > > -{ > > > - CPUState *cs = mon_get_cpu(mon); > > > - > > > - if (!cs) { > > > - monitor_printf(mon, "No CPU available\n"); > > > - return; > > > - } > > > - cpu_dump_statistics(cs, 0); > > > -} > > > - > > > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > > > { > > > const char *name = qdict_get_try_str(qdict, "name"); > >
On 27/05/2021 05:30, Greg Kurz wrote: > On Thu, 27 May 2021 09:09:55 +0100 > "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote: > >> * Greg Kurz (groug@kaod.org) wrote: >>> On Wed, 26 May 2021 17:21:03 -0300 >>> "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: >>> >>>> Since ppc was the last architecture to collect these statistics and >>>> it is currently phasing this collection out, the command that would query >>>> this information is being removed. >>>> >>> So this is removing an obviously user visible feature. This should be >>> mentioned in docs/system/removed-features.rst... but, wait, I don't >>> see anything for it in docs/system/deprecated.rst. This is dropping >>> a feature without following the usual deprecation policy, i.e. >>> marking the feature as deprecated and only remove it 2 QEMU versions >>> later. Any justification for that ? The command called a function that ultimately called an empty callback unless you changed target/ppc/translate.c and removed the comments around #define DO_PPC_STATISTICS. And like I mentioned in the cover letter (which may not have been CC'ed to you, sorry) ppc was the last architecture to support this feature while they were using the legacy decode system, but as they move to decodetree, this data wouldn't even be collected. That's the justification, basically. >> As long as the command really isn't useful any more, I wouldn't object >> to that from an HMP point of view. >> > Ok then this should be documented in docs/system/removed-features.rst at > least. Sure, will send a patch later today with the update > >> Dave >> >>> David, >>> >>> Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab >>> but the commit title appears to be broken: >>> >>> '65;6401;1cmonitor: removed cpustats command >>> >>> https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 >>> >>>> Suggested-by: Richard Henderson <richard.henderson@linaro.org> >>>> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> >>>> --- >>>> hmp-commands-info.hx | 13 ------------- >>>> monitor/misc.c | 11 ----------- >>>> 2 files changed, 24 deletions(-) >>>> >>>> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx >>>> index ab0c7aa5ee..b2347a6aea 100644 >>>> --- a/hmp-commands-info.hx >>>> +++ b/hmp-commands-info.hx >>>> @@ -500,19 +500,6 @@ SRST >>>> Show the current VM UUID. >>>> ERST >>>> >>>> - { >>>> - .name = "cpustats", >>>> - .args_type = "", >>>> - .params = "", >>>> - .help = "show CPU statistics", >>>> - .cmd = hmp_info_cpustats, >>>> - }, >>>> - >>>> -SRST >>>> - ``info cpustats`` >>>> - Show CPU statistics. >>>> -ERST >>>> - >>>> #if defined(CONFIG_SLIRP) >>>> { >>>> .name = "usernet", >>>> diff --git a/monitor/misc.c b/monitor/misc.c >>>> index f3a393ea59..1539e18557 100644 >>>> --- a/monitor/misc.c >>>> +++ b/monitor/misc.c >>>> @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) >>>> } >>>> } >>>> >>>> -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) >>>> -{ >>>> - CPUState *cs = mon_get_cpu(mon); >>>> - >>>> - if (!cs) { >>>> - monitor_printf(mon, "No CPU available\n"); >>>> - return; >>>> - } >>>> - cpu_dump_statistics(cs, 0); >>>> -} >>>> - >>>> static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) >>>> { >>>> const char *name = qdict_get_try_str(qdict, "name");
On Thu, 27 May 2021 08:24:40 -0300 Bruno Piazera Larsen <bruno.larsen@eldorado.org.br> wrote: > > On 27/05/2021 05:30, Greg Kurz wrote: > > On Thu, 27 May 2021 09:09:55 +0100 > > "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote: > > > >> * Greg Kurz (groug@kaod.org) wrote: > >>> On Wed, 26 May 2021 17:21:03 -0300 > >>> "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > >>> > >>>> Since ppc was the last architecture to collect these statistics and > >>>> it is currently phasing this collection out, the command that would query > >>>> this information is being removed. > >>>> > >>> So this is removing an obviously user visible feature. This should be > >>> mentioned in docs/system/removed-features.rst... but, wait, I don't > >>> see anything for it in docs/system/deprecated.rst. This is dropping > >>> a feature without following the usual deprecation policy, i.e. > >>> marking the feature as deprecated and only remove it 2 QEMU versions > >>> later. Any justification for that ? > > The command called a function that ultimately called an empty callback > unless you changed target/ppc/translate.c and removed the comments > around #define DO_PPC_STATISTICS. And like I mentioned in the cover > letter (which may not have been CC'ed to you, sorry) ppc was the last > architecture to support this feature while they were using the legacy > decode system, but as they move to decodetree, this data wouldn't even > be collected. > > That's the justification, basically. > So to sum up, this HMP command doesn't produce any output with upstream QEMU. Add a section in docs/system/removed-features.rst and just mention that. Not worth reposting the full series just for that. This can be done in a followup patch. > >> As long as the command really isn't useful any more, I wouldn't object > >> to that from an HMP point of view. > >> > > Ok then this should be documented in docs/system/removed-features.rst at > > least. > Sure, will send a patch later today with the update > > > >> Dave > >> > >>> David, > >>> > >>> Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab > >>> but the commit title appears to be broken: > >>> > >>> '65;6401;1cmonitor: removed cpustats command > >>> > >>> https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 > >>> > >>>> Suggested-by: Richard Henderson <richard.henderson@linaro.org> > >>>> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> > >>>> --- > >>>> hmp-commands-info.hx | 13 ------------- > >>>> monitor/misc.c | 11 ----------- > >>>> 2 files changed, 24 deletions(-) > >>>> > >>>> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > >>>> index ab0c7aa5ee..b2347a6aea 100644 > >>>> --- a/hmp-commands-info.hx > >>>> +++ b/hmp-commands-info.hx > >>>> @@ -500,19 +500,6 @@ SRST > >>>> Show the current VM UUID. > >>>> ERST > >>>> > >>>> - { > >>>> - .name = "cpustats", > >>>> - .args_type = "", > >>>> - .params = "", > >>>> - .help = "show CPU statistics", > >>>> - .cmd = hmp_info_cpustats, > >>>> - }, > >>>> - > >>>> -SRST > >>>> - ``info cpustats`` > >>>> - Show CPU statistics. > >>>> -ERST > >>>> - > >>>> #if defined(CONFIG_SLIRP) > >>>> { > >>>> .name = "usernet", > >>>> diff --git a/monitor/misc.c b/monitor/misc.c > >>>> index f3a393ea59..1539e18557 100644 > >>>> --- a/monitor/misc.c > >>>> +++ b/monitor/misc.c > >>>> @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > >>>> } > >>>> } > >>>> > >>>> -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > >>>> -{ > >>>> - CPUState *cs = mon_get_cpu(mon); > >>>> - > >>>> - if (!cs) { > >>>> - monitor_printf(mon, "No CPU available\n"); > >>>> - return; > >>>> - } > >>>> - cpu_dump_statistics(cs, 0); > >>>> -} > >>>> - > >>>> static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > >>>> { > >>>> const char *name = qdict_get_try_str(qdict, "name");
Greg Kurz <groug@kaod.org> writes: > On Wed, 26 May 2021 17:21:03 -0300 > "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > >> Since ppc was the last architecture to collect these statistics and >> it is currently phasing this collection out, the command that would query >> this information is being removed. >> > > So this is removing an obviously user visible feature. This should be > mentioned in docs/system/removed-features.rst... but, wait, I don't > see anything for it in docs/system/deprecated.rst. This is dropping > a feature without following the usual deprecation policy, i.e. > marking the feature as deprecated and only remove it 2 QEMU versions > later. Any justification for that ? Our deprecation policy applies to stable interfaces, which HMP is not. We don't break things there just because. But dropping a command right away when it is no longer useful is just fine. No need to deprecate and wait for the grace period. [...]
On Tue, 08 Jun 2021 17:10:32 +0200 Markus Armbruster <armbru@redhat.com> wrote: > Greg Kurz <groug@kaod.org> writes: > > > On Wed, 26 May 2021 17:21:03 -0300 > > "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote: > > > >> Since ppc was the last architecture to collect these statistics and > >> it is currently phasing this collection out, the command that would query > >> this information is being removed. > >> > > > > So this is removing an obviously user visible feature. This should be > > mentioned in docs/system/removed-features.rst... but, wait, I don't > > see anything for it in docs/system/deprecated.rst. This is dropping > > a feature without following the usual deprecation policy, i.e. > > marking the feature as deprecated and only remove it 2 QEMU versions > > later. Any justification for that ? > > Our deprecation policy applies to stable interfaces, which HMP is not. > > We don't break things there just because. But dropping a command right > away when it is no longer useful is just fine. No need to deprecate and > wait for the grace period. > > [...] > Ah, good to know. Thanks! -- Greg
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index ab0c7aa5ee..b2347a6aea 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -500,19 +500,6 @@ SRST Show the current VM UUID. ERST - { - .name = "cpustats", - .args_type = "", - .params = "", - .help = "show CPU statistics", - .cmd = hmp_info_cpustats, - }, - -SRST - ``info cpustats`` - Show CPU statistics. -ERST - #if defined(CONFIG_SLIRP) { .name = "usernet", diff --git a/monitor/misc.c b/monitor/misc.c index f3a393ea59..1539e18557 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) } } -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) -{ - CPUState *cs = mon_get_cpu(mon); - - if (!cs) { - monitor_printf(mon, "No CPU available\n"); - return; - } - cpu_dump_statistics(cs, 0); -} - static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) { const char *name = qdict_get_try_str(qdict, "name");
Since ppc was the last architecture to collect these statistics and it is currently phasing this collection out, the command that would query this information is being removed. Suggested-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br> --- hmp-commands-info.hx | 13 ------------- monitor/misc.c | 11 ----------- 2 files changed, 24 deletions(-)