| Message ID | 20210605174938.13782-1-email@aabouzied.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] Remove leading underscores from QEMU defines | expand |
On 05/06/2021 19.49, Ahmed Abouzied wrote: > Leading underscores followed by a capital letter or underscore are > reserved by the C standard. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 > > Signed-off-by: Ahmed Abouzied <email@aabouzied.com> > --- > include/fpu/softfloat-helpers.h | 4 ++-- > include/hw/usb/dwc2-regs.h | 4 ++-- > include/hw/usb/xlnx-usb-subsystem.h | 4 ++-- > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 4 ++-- > include/qemu/plugin-memory.h | 4 ++-- > include/qemu/selfmap.h | 4 ++-- > include/user/syscall-trace.h | 4 ++-- > plugins/plugin.h | 4 ++-- > tests/qtest/fuzz/qos_fuzz.h | 4 ++-- > tests/tcg/minilib/minilib.h | 4 ++-- > 10 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/include/fpu/softfloat-helpers.h b/include/fpu/softfloat-helpers.h index 34f4cf92ae..a98d759cd3 100644 --- a/include/fpu/softfloat-helpers.h +++ b/include/fpu/softfloat-helpers.h @@ -48,8 +48,8 @@ this code that are retained. =============================================================================== */ -#ifndef _SOFTFLOAT_HELPERS_H_ -#define _SOFTFLOAT_HELPERS_H_ +#ifndef SOFTFLOAT_HELPERS_H +#define SOFTFLOAT_HELPERS_H #include "fpu/softfloat-types.h" diff --git a/include/hw/usb/dwc2-regs.h b/include/hw/usb/dwc2-regs.h index 40af23a0ba..a7eb531485 100644 --- a/include/hw/usb/dwc2-regs.h +++ b/include/hw/usb/dwc2-regs.h @@ -39,8 +39,8 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#ifndef __DWC2_HW_H__ -#define __DWC2_HW_H__ +#ifndef DWC2_HW_H +#define DWC2_HW_H #define HSOTG_REG(x) (x) diff --git a/include/hw/usb/xlnx-usb-subsystem.h b/include/hw/usb/xlnx-usb-subsystem.h index 739bef7f45..999e423951 100644 --- a/include/hw/usb/xlnx-usb-subsystem.h +++ b/include/hw/usb/xlnx-usb-subsystem.h @@ -22,8 +22,8 @@ * THE SOFTWARE. */ -#ifndef _XLNX_VERSAL_USB_SUBSYSTEM_H_ -#define _XLNX_VERSAL_USB_SUBSYSTEM_H_ +#ifndef XLNX_VERSAL_USB_SUBSYSTEM_H +#define XLNX_VERSAL_USB_SUBSYSTEM_H #include "hw/usb/xlnx-versal-usb2-ctrl-regs.h" #include "hw/usb/hcd-dwc3.h" diff --git a/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h b/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h index 975a717627..b76dce0419 100644 --- a/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h +++ b/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h @@ -23,8 +23,8 @@ * THE SOFTWARE. */ -#ifndef _XLNX_USB2_REGS_H_ -#define _XLNX_USB2_REGS_H_ +#ifndef XLNX_USB2_REGS_H +#define XLNX_USB2_REGS_H #define TYPE_XILINX_VERSAL_USB2_CTRL_REGS "xlnx.versal-usb2-ctrl-regs" diff --git a/include/qemu/plugin-memory.h b/include/qemu/plugin-memory.h index fbbe99474b..b36def27d7 100644 --- a/include/qemu/plugin-memory.h +++ b/include/qemu/plugin-memory.h @@ -6,8 +6,8 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -#ifndef _PLUGIN_MEMORY_H_ -#define _PLUGIN_MEMORY_H_ +#ifndef PLUGIN_MEMORY_H +#define PLUGIN_MEMORY_H struct qemu_plugin_hwaddr { bool is_io; diff --git a/include/qemu/selfmap.h b/include/qemu/selfmap.h index 8382c4c779..80cf920fba 100644 --- a/include/qemu/selfmap.h +++ b/include/qemu/selfmap.h @@ -6,8 +6,8 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -#ifndef _SELFMAP_H_ -#define _SELFMAP_H_ +#ifndef SELFMAP_H +#define SELFMAP_H typedef struct { unsigned long start; diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h index 42e3b48b03..614cfacfa5 100644 --- a/include/user/syscall-trace.h +++ b/include/user/syscall-trace.h @@ -7,8 +7,8 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -#ifndef _SYSCALL_TRACE_H_ -#define _SYSCALL_TRACE_H_ +#ifndef SYSCALL_TRACE_H +#define SYSCALL_TRACE_H #include "trace/trace-root.h" diff --git a/plugins/plugin.h b/plugins/plugin.h index 55017e3581..b13677d0dc 100644 --- a/plugins/plugin.h +++ b/plugins/plugin.h @@ -9,8 +9,8 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -#ifndef _PLUGIN_INTERNAL_H_ -#define _PLUGIN_INTERNAL_H_ +#ifndef PLUGIN_INTERNAL_H +#define PLUGIN_INTERNAL_H #include <gmodule.h> #include "qemu/qht.h" diff --git a/tests/qtest/fuzz/qos_fuzz.h b/tests/qtest/fuzz/qos_fuzz.h index 477f11b02b..63d8459b71 100644 --- a/tests/qtest/fuzz/qos_fuzz.h +++ b/tests/qtest/fuzz/qos_fuzz.h @@ -10,8 +10,8 @@ * See the COPYING file in the top-level directory. */ -#ifndef _QOS_FUZZ_H_ -#define _QOS_FUZZ_H_ +#ifndef QOS_FUZZ_H +#define QOS_FUZZ_H #include "tests/qtest/fuzz/fuzz.h" #include "tests/qtest/libqos/qgraph.h" diff --git a/tests/tcg/minilib/minilib.h b/tests/tcg/minilib/minilib.h index e23361380a..17d0f2f314 100644 --- a/tests/tcg/minilib/minilib.h +++ b/tests/tcg/minilib/minilib.h @@ -9,8 +9,8 @@ * SPDX-License-Identifier: GPL-2.0-only */ -#ifndef _MINILIB_H_ -#define _MINILIB_H_ +#ifndef MINILIB_H +#define MINILIB_H /* * Provided by the individual arch
Leading underscores followed by a capital letter or underscore are reserved by the C standard. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 Signed-off-by: Ahmed Abouzied <email@aabouzied.com> --- include/fpu/softfloat-helpers.h | 4 ++-- include/hw/usb/dwc2-regs.h | 4 ++-- include/hw/usb/xlnx-usb-subsystem.h | 4 ++-- include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 4 ++-- include/qemu/plugin-memory.h | 4 ++-- include/qemu/selfmap.h | 4 ++-- include/user/syscall-trace.h | 4 ++-- plugins/plugin.h | 4 ++-- tests/qtest/fuzz/qos_fuzz.h | 4 ++-- tests/tcg/minilib/minilib.h | 4 ++-- 10 files changed, 20 insertions(+), 20 deletions(-)