diff mbox series

[PULL,13/13] usb/dev-mtp: use GDateTime for formatting timestamp for objects

Message ID 20210614141549.100410-14-berrange@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,01/13] docs: add table of contents to QAPI references | expand

Commit Message

Daniel P. Berrangé June 14, 2021, 2:15 p.m. UTC
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 hw/usb/dev-mtp.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
diff mbox series


diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 2a895a73b0..c1d1694fd0 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -772,12 +772,9 @@  static void usb_mtp_add_str(MTPData *data, const char *str)
 static void usb_mtp_add_time(MTPData *data, time_t time)
-    char buf[16];
-    struct tm tm;
-    gmtime_r(&time, &tm);
-    strftime(buf, sizeof(buf), "%Y%m%dT%H%M%S", &tm);
-    usb_mtp_add_str(data, buf);
+    g_autoptr(GDateTime) then = g_date_time_new_from_unix_utc(time);
+    g_autofree char *thenstr = g_date_time_format(then, "%Y%m%dT%H%M%S");
+    usb_mtp_add_str(data, thenstr);
 /* ----------------------------------------------------------------------- */