| Message ID | 20210614161243.14211-1-peter.maydell@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/intc/armv7m_nvic: Remove stale comment | expand |
On 6/14/21 6:12 PM, Peter Maydell wrote: > In commit da6d674e509f0939b we split the NVIC code out from the GIC. > This allowed us to specify the NVIC's default value for the num-irq > property (64) in the usual way in its property list, and we deleted > the previous hack where we updated the value in the state struct in > the instance init function. Remove a stale comment about that hack > which we forgot to delete at that time. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/intc/armv7m_nvic.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 6/14/21 9:12 AM, Peter Maydell wrote: > In commit da6d674e509f0939b we split the NVIC code out from the GIC. > This allowed us to specify the NVIC's default value for the num-irq > property (64) in the usual way in its property list, and we deleted > the previous hack where we updated the value in the state struct in > the instance init function. Remove a stale comment about that hack > which we forgot to delete at that time. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > hw/intc/armv7m_nvic.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c index c4287d82d81..94fe00235af 100644 --- a/hw/intc/armv7m_nvic.c +++ b/hw/intc/armv7m_nvic.c @@ -2941,12 +2941,6 @@ static void armv7m_nvic_realize(DeviceState *dev, Error **errp) static void armv7m_nvic_instance_init(Object *obj) { - /* We have a different default value for the num-irq property - * than our superclass. This function runs after qdev init - * has set the defaults from the Property array and before - * any user-specified property setting, so just modify the - * value in the GICState struct. - */ DeviceState *dev = DEVICE(obj); NVICState *nvic = NVIC(obj); SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
In commit da6d674e509f0939b we split the NVIC code out from the GIC. This allowed us to specify the NVIC's default value for the num-irq property (64) in the usual way in its property list, and we deleted the previous hack where we updated the value in the state struct in the instance init function. Remove a stale comment about that hack which we forgot to delete at that time. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/intc/armv7m_nvic.c | 6 ------ 1 file changed, 6 deletions(-)