[v2,3/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint()

Commit Message

Philippe Mathieu-Daudé June 15, 2021, 4:47 p.m. UTC

Avoid accessing QCryptoTLSCreds internals by using
the qcrypto_tls_creds_check_endpoint() helper.

Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 chardev/char-socket.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index daa89fe5d1d..fe6b1fe2110 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -1403,13 +1403,15 @@  static void qmp_chardev_open_socket(Chardev *chr,
         }
         object_ref(OBJECT(s->tls_creds));
         if (is_listen) {
-            if (s->tls_creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) {
+            if (!qcrypto_tls_creds_check_endpoint(s->tls_creds,
+                                        QCRYPTO_TLS_CREDS_ENDPOINT_SERVER)) {
                 error_setg(errp, "%s",
                            "Expected TLS credentials for server endpoint");
                 return;
             }
         } else {
-            if (s->tls_creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT) {
+            if (!qcrypto_tls_creds_check_endpoint(s->tls_creds,
+                                        QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT)) {
                 error_setg(errp, "%s",
                            "Expected TLS credentials for client endpoint");
                 return;