From patchwork Wed Jun 16 01:11:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 12323651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1B2C49EA4 for ; Wed, 16 Jun 2021 01:23:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0517B613B3 for ; Wed, 16 Jun 2021 01:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0517B613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltKHe-0003oX-5z for qemu-devel@archiver.kernel.org; Tue, 15 Jun 2021 21:23:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltK6Q-0005PC-NE for qemu-devel@nongnu.org; Tue, 15 Jun 2021 21:12:22 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:35693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltK6L-0008Nx-01 for qemu-devel@nongnu.org; Tue, 15 Jun 2021 21:12:22 -0400 Received: by mail-pg1-x532.google.com with SMTP id v7so593949pgl.2 for ; Tue, 15 Jun 2021 18:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FJ88hjzMPCGkvsQLrCHEXf9qcVpoODBdkqIpV1aB2qU=; b=QGFgaaDcyTvM1hVoJGpb7bJ2+HaGfWLBYjhelO9M0wKD3OCtpEs8mnZANdkFVYsZZT I6/x2CsNq2nyX17DzaEjOKdy5oLvUeEHbOks6sC4MpLcs13y9xLYBTNN1n2gcU+XTId2 Tx73gHVaGPpidUA7UhHgv9g9HmWxQ7TAtaw/QVdzY9zUhSQa4yi8665rlFv3yzvz5fMm KXQ5zGKtO2v+1prBRm+lJSUx4Bw4heZKgFEEKmYDPCDi+YM1PN25au8qELaG9cgByasl dY6el2ir2402rkvSlcSmlQvhe9aeVCwQY/PYSnmf7faxk1cOyNko1llcqYaK2Ys7FLhr Xm2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FJ88hjzMPCGkvsQLrCHEXf9qcVpoODBdkqIpV1aB2qU=; b=XZmNunCgYsmhI83XLyE9MB6GfCxlmWqbElfk4NhPlhlXahk72nkscRMPLpUPCd71i4 4lU4eCZEovMU8K+1u8h+Pig/xzZvsk984uwUzG0jtrTWfYPmYCgw+DOcwNC6XYtOsqtB c0+e0QHT/pkbwvdR+nmxSNTH1ebaI2Mt+33xM2EjPXZTDRedtrHFxxppT9CyB56ciGG5 ZiWW+TK6HzpaGEb4jBxooRACLzm7sjq4k6fIcC/reAYY4mvWkOyFzRiI1KhDqKtgGtzu XiB8SYDk3y8fPxs9K5GNqFApC2h8CBQcKsOWJiEb5yaguh5e9xfHEUt5JKPpzEx5+Ljh yXIg== X-Gm-Message-State: AOAM53150dONjROBDSEVBtQhDjJfoTh/IokOYleHPcplomd2yR68YgqH Db5QN16LjMthpillauw50yIJlnwBzYpY9w== X-Google-Smtp-Source: ABdhPJwUjrzO7EXnZ4ILOjMm1Qj80fJiRZoCWtwMK489eJdKyNpkd1yFZt9/AaznNqNIiuCMdSSdWg== X-Received: by 2002:a63:6884:: with SMTP id d126mr2381817pgc.368.1623805935732; Tue, 15 Jun 2021 18:12:15 -0700 (PDT) Received: from localhost.localdomain (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id y18sm305297pgk.53.2021.06.15.18.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 18:12:15 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp Date: Tue, 15 Jun 2021 18:11:56 -0700 Message-Id: <20210616011209.1446045-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210616011209.1446045-1-richard.henderson@linaro.org> References: <20210616011209.1446045-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" We cannot use a raw sigtramp page for hppa, but must wait for full vdso support. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- linux-user/hppa/target_signal.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h index 7f525362e9..d558119ee7 100644 --- a/linux-user/hppa/target_signal.h +++ b/linux-user/hppa/target_signal.h @@ -71,4 +71,18 @@ typedef struct target_sigaltstack { /* mask for all SS_xxx flags */ #define TARGET_SS_FLAG_BITS TARGET_SS_AUTODISARM +/* + * We cannot use a bare sigtramp page for hppa-linux. + * + * Unlike other guests where we use the instructions at PC to validate + * an offset from SP, the hppa libgcc signal frame fallback unwinding uses + * the PC address itself to find the frame. This is due to the fact that + * the hppa grows the stack upward, and the frame is of unknown size. + * + * TODO: We should be able to use a VDSO to address this, by providing + * proper unwind info for the sigtramp code, at which point the fallback + * unwinder will not be used. + */ +#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 0 + #endif /* HPPA_TARGET_SIGNAL_H */