| Message ID | 20210621041650.5826-2-jasowang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vhost-vDPA multiqueue | expand |
On Mon, Jun 21, 2021 at 12:16:33PM +0800, Jason Wang wrote: > The nvqs and vqs has been initialized during vhost_net_init() and is I suggest "nvqs and vqs have been initialized during vhost_net_init() and are not..." Other than that Reviewed-by: Eli Cohen <elic@nvidia.com> > not expected to change during the life cycle of vhost_net > structure. So this patch removes the meaningless assignment. > > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > hw/net/vhost_net.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index 44c1ed92dc..6bd4184f96 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -238,9 +238,6 @@ static int vhost_net_start_one(struct vhost_net *net, > struct vhost_vring_file file = { }; > int r; > > - net->dev.nvqs = 2; > - net->dev.vqs = net->vqs; > - > r = vhost_dev_enable_notifiers(&net->dev, dev); > if (r < 0) { > goto fail_notifiers; > -- > 2.25.1 >
在 2021/6/21 下午7:45, Eli Cohen 写道: > On Mon, Jun 21, 2021 at 12:16:33PM +0800, Jason Wang wrote: >> The nvqs and vqs has been initialized during vhost_net_init() and is > I suggest "nvqs and vqs have been initialized during vhost_net_init() and > are not..." > Other than that > Reviewed-by: Eli Cohen <elic@nvidia.com> Will fix. Thanks > >> not expected to change during the life cycle of vhost_net >> structure. So this patch removes the meaningless assignment. >> >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> hw/net/vhost_net.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c >> index 44c1ed92dc..6bd4184f96 100644 >> --- a/hw/net/vhost_net.c >> +++ b/hw/net/vhost_net.c >> @@ -238,9 +238,6 @@ static int vhost_net_start_one(struct vhost_net *net, >> struct vhost_vring_file file = { }; >> int r; >> >> - net->dev.nvqs = 2; >> - net->dev.vqs = net->vqs; >> - >> r = vhost_dev_enable_notifiers(&net->dev, dev); >> if (r < 0) { >> goto fail_notifiers; >> -- >> 2.25.1 >>
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 44c1ed92dc..6bd4184f96 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -238,9 +238,6 @@ static int vhost_net_start_one(struct vhost_net *net, struct vhost_vring_file file = { }; int r; - net->dev.nvqs = 2; - net->dev.vqs = net->vqs; - r = vhost_dev_enable_notifiers(&net->dev, dev); if (r < 0) { goto fail_notifiers;
The nvqs and vqs has been initialized during vhost_net_init() and is not expected to change during the life cycle of vhost_net structure. So this patch removes the meaningless assignment. Signed-off-by: Jason Wang <jasowang@redhat.com> --- hw/net/vhost_net.c | 3 --- 1 file changed, 3 deletions(-)