mbox

[PULL,00/37] s390x update

Message ID 20210621095842.335162-1-cohuck@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://gitlab.com/cohuck/qemu.git tags/s390x-20210621

Message

Cornelia Huck June 21, 2021, 9:58 a.m. UTC 
The following changes since commit 8f521741e1280f0957ac1b873292c19219e1fb9a:

  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210618.0' into staging (2021-06-18 16:42:25 +0100)

are available in the Git repository at:

  https://gitlab.com/cohuck/qemu.git tags/s390x-20210621

for you to fetch changes up to c626710fc755628d0d6b88aab0514c9238a84522:

  s390x/css: Add passthrough IRB (2021-06-21 08:48:21 +0200)

----------------------------------------------------------------
s390x update:
- tcg: implement the vector enhancements facility and bump the
  'qemu' cpu model to a stripped-down z14 GA2
- fix psw.mask handling in signals
- fix vfio-ccw sense data handling

----------------------------------------------------------------

Cornelia Huck (1):
  s390x/kvm: remove unused gs handling

David Hildenbrand (26):
  s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling
  s390x/tcg: Fix instruction name for VECTOR FP LOAD
    (LENGTHENED|ROUNDED)
  s390x/tcg: Simplify vop64_3() handling
  s390x/tcg: Simplify vop64_2() handling
  s390x/tcg: Simplify vfc64() handling
  s390x/tcg: Simplify vftci64() handling
  s390x/tcg: Simplify vfma64() handling
  s390x/tcg: Simplify vfll32() handling
  s390x/tcg: Simplify vflr64() handling
  s390x/tcg: Simplify wfc64() handling
  s390x/tcg: Implement VECTOR BIT PERMUTE
  s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL
  s390x/tcg: Implement 32/128 bit for VECTOR FP
    (ADD|DIVIDE|MULTIPLY|SUBTRACT)
  s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE
    ROOT)
  s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *
  s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL)
    SCALAR
  s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED
  s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED
  s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION
  s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS
    IMMEDIATE
  s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND
    (ADD|SUBTRACT)
  s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)
  s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)
  linux-user: elf: s390x: Prepare for Vector enhancements facility
  s390x/tcg: We support Vector enhancements facility
  s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

Eric Farman (4):
  s390x/css: Introduce an ESW struct
  s390x/css: Split out the IRB sense data
  s390x/css: Refactor IRB construction
  s390x/css: Add passthrough IRB

Richard Henderson (5):
  target/s390x: Expose load_psw and get_psw_mask to cpu.h
  target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask
  target/s390x: Improve s390_cpu_dump_state vs cc_op
  target/s390x: Use s390_cpu_{set_psw, get_psw_mask} in gdbstub
  linux-user/s390x: Save and restore psw.mask properly

Thomas Huth (1):
  configure: Check whether we can compile the s390-ccw bios with
    -msoft-float

 configure                       |    2 +-
 hw/s390x/3270-ccw.c             |    1 +
 hw/s390x/css.c                  |   87 ++-
 hw/s390x/s390-ccw.c             |    1 +
 hw/s390x/s390-virtio-ccw.c      |    3 +
 hw/s390x/virtio-ccw.c           |    1 +
 hw/vfio/ccw.c                   |    4 +
 include/elf.h                   |    7 +
 include/hw/s390x/css.h          |    5 +
 include/hw/s390x/ioinst.h       |   12 +-
 linux-user/elfload.c            |    1 +
 linux-user/s390x/signal.c       |   37 +-
 target/s390x/cc_helper.c        |    2 +-
 target/s390x/cpu.h              |    3 +
 target/s390x/cpu_models.c       |    4 +-
 target/s390x/excp_helper.c      |   28 +-
 target/s390x/fpu_helper.c       |   41 +-
 target/s390x/gdbstub.c          |   15 +-
 target/s390x/gen-features.c     |   14 +-
 target/s390x/helper.c           |  101 +--
 target/s390x/helper.h           |   70 +-
 target/s390x/insn-data.def      |   16 +-
 target/s390x/internal.h         |   14 +-
 target/s390x/kvm-stub.c         |    5 -
 target/s390x/kvm.c              |   10 +-
 target/s390x/kvm_s390x.h        |    1 -
 target/s390x/sigp.c             |    3 +-
 target/s390x/translate_vx.c.inc |  633 ++++++++++++++----
 target/s390x/vec_fpu_helper.c   | 1079 ++++++++++++++++++++++---------
 target/s390x/vec_helper.c       |   22 +
 30 files changed, 1626 insertions(+), 596 deletions(-)

Comments

no-reply@patchew.org June 21, 2021, 10:39 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20210621095842.335162-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210621095842.335162-1-cohuck@redhat.com
Subject: [PULL 00/37] s390x update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8f52174..e4bfa6c  master     -> master
 * [new tag]         patchew/20210621095842.335162-1-cohuck@redhat.com -> patchew/20210621095842.335162-1-cohuck@redhat.com
Switched to a new branch 'test'
89df28e s390x/css: Add passthrough IRB
1cbff5a s390x/css: Refactor IRB construction
f8c6120 s390x/css: Split out the IRB sense data
4661ebe s390x/css: Introduce an ESW struct
b54d90b linux-user/s390x: Save and restore psw.mask properly
635ee2f target/s390x: Use s390_cpu_{set_psw, get_psw_mask} in gdbstub
58eccac target/s390x: Improve s390_cpu_dump_state vs cc_op
590d47d target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask
e887639 target/s390x: Expose load_psw and get_psw_mask to cpu.h
f848726 configure: Check whether we can compile the s390-ccw bios with -msoft-float
2e4e10b s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2
9bf7b55 s390x/tcg: We support Vector enhancements facility
4487ef2 linux-user: elf: s390x: Prepare for Vector enhancements facility
a3a7d21 s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)
7e4827c s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)
a84f6fc s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT)
794d69a s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE
11ad7c9 s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION
ae6979e s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED
61872e7 s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED
e611b14 s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALAR
904505d s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *
c1396b3 s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)
599077a s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)
073a3b9 s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL
af9ec72 s390x/tcg: Implement VECTOR BIT PERMUTE
cf3be3a s390x/tcg: Simplify wfc64() handling
684c87b s390x/tcg: Simplify vflr64() handling
ae1579c s390x/tcg: Simplify vfll32() handling
8eb5277 s390x/tcg: Simplify vfma64() handling
abe65a0 s390x/tcg: Simplify vftci64() handling
6cd5ded s390x/tcg: Simplify vfc64() handling
75490b3 s390x/tcg: Simplify vop64_2() handling
68333d5 s390x/tcg: Simplify vop64_3() handling
c107a61 s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)
482906e s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling
425b872 s390x/kvm: remove unused gs handling

=== OUTPUT BEGIN ===
1/37 Checking commit 425b8721db83 (s390x/kvm: remove unused gs handling)
2/37 Checking commit 482906ed0f93 (s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling)
3/37 Checking commit c107a6181384 (s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED))
4/37 Checking commit 68333d543eae (s390x/tcg: Simplify vop64_3() handling)
5/37 Checking commit 75490b366d72 (s390x/tcg: Simplify vop64_2() handling)
6/37 Checking commit 6cd5ded287fa (s390x/tcg: Simplify vfc64() handling)
7/37 Checking commit abe65a0b9194 (s390x/tcg: Simplify vftci64() handling)
8/37 Checking commit 8eb5277b12a8 (s390x/tcg: Simplify vfma64() handling)
9/37 Checking commit ae1579cd608a (s390x/tcg: Simplify vfll32() handling)
10/37 Checking commit 684c87b68e58 (s390x/tcg: Simplify vflr64() handling)
11/37 Checking commit cf3be3aaa7a3 (s390x/tcg: Simplify wfc64() handling)
12/37 Checking commit af9ec72f5918 (s390x/tcg: Implement VECTOR BIT PERMUTE)
13/37 Checking commit 073a3b99cb58 (s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL)
14/37 Checking commit 599077a525f8 (s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT))
15/37 Checking commit c1396b3639dd (s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT))
16/37 Checking commit 904505d2b4a1 (s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *)
WARNING: line over 80 characters
#33: FILE: target/s390x/helper.h:259:
+DEF_HELPER_FLAGS_5(gvec_vfce128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#39: FILE: target/s390x/helper.h:265:
+DEF_HELPER_FLAGS_5(gvec_vfch128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#41: FILE: target/s390x/helper.h:267:
+DEF_HELPER_FLAGS_5(gvec_vfche32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#45: FILE: target/s390x/helper.h:271:
+DEF_HELPER_FLAGS_5(gvec_vfche128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

total: 0 errors, 4 warnings, 190 lines checked

Patch 16/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/37 Checking commit e611b14986f3 (s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALAR)
18/37 Checking commit 61872e7578c7 (s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED)
19/37 Checking commit ae6979ea5c03 (s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED)
20/37 Checking commit 11ad7c93b141 (s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION)
21/37 Checking commit 794d69ab638b (s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE)
22/37 Checking commit a84f6fc84a63 (s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT))
WARNING: line over 80 characters
#26: FILE: target/s390x/helper.h:294:
+DEF_HELPER_FLAGS_6(gvec_vfma32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#28: FILE: target/s390x/helper.h:296:
+DEF_HELPER_FLAGS_6(gvec_vfma128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#29: FILE: target/s390x/helper.h:297:
+DEF_HELPER_FLAGS_6(gvec_vfms32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#31: FILE: target/s390x/helper.h:299:
+DEF_HELPER_FLAGS_6(gvec_vfms128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

ERROR: spaces required around that '*' (ctx:WxV)
#44: FILE: target/s390x/translate_vx.c.inc:2821:
+    gen_helper_gvec_4_ptr *fn = NULL;
                           ^

total: 1 errors, 4 warnings, 132 lines checked

Patch 22/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

23/37 Checking commit 7e4827cdef8e (s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT))
WARNING: line over 80 characters
#27: FILE: target/s390x/helper.h:300:
+DEF_HELPER_FLAGS_6(gvec_vfnma32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#28: FILE: target/s390x/helper.h:301:
+DEF_HELPER_FLAGS_6(gvec_vfnma64, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#29: FILE: target/s390x/helper.h:302:
+DEF_HELPER_FLAGS_6(gvec_vfnma128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#30: FILE: target/s390x/helper.h:303:
+DEF_HELPER_FLAGS_6(gvec_vfnms32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#31: FILE: target/s390x/helper.h:304:
+DEF_HELPER_FLAGS_6(gvec_vfnms64, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#32: FILE: target/s390x/helper.h:305:
+DEF_HELPER_FLAGS_6(gvec_vfnms128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, cptr, env, i32)

total: 0 errors, 6 warnings, 87 lines checked

Patch 23/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/37 Checking commit a3a7d21afa75 (s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM))
WARNING: line over 80 characters
#33: FILE: target/s390x/helper.h:294:
+DEF_HELPER_FLAGS_5(gvec_vfmax32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#34: FILE: target/s390x/helper.h:295:
+DEF_HELPER_FLAGS_5(gvec_vfmax64, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#35: FILE: target/s390x/helper.h:296:
+DEF_HELPER_FLAGS_5(gvec_vfmax128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#36: FILE: target/s390x/helper.h:297:
+DEF_HELPER_FLAGS_5(gvec_vfmin32, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#37: FILE: target/s390x/helper.h:298:
+DEF_HELPER_FLAGS_5(gvec_vfmin64, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

WARNING: line over 80 characters
#38: FILE: target/s390x/helper.h:299:
+DEF_HELPER_FLAGS_5(gvec_vfmin128, TCG_CALL_NO_WG, void, ptr, cptr, cptr, env, i32)

total: 0 errors, 6 warnings, 418 lines checked

Patch 24/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/37 Checking commit 4487ef2e625b (linux-user: elf: s390x: Prepare for Vector enhancements facility)
26/37 Checking commit 9bf7b55758d6 (s390x/tcg: We support Vector enhancements facility)
27/37 Checking commit 2e4e10b56d9f (s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2)
28/37 Checking commit f848726142a8 (configure: Check whether we can compile the s390-ccw bios with -msoft-float)
29/37 Checking commit e88763918f17 (target/s390x: Expose load_psw and get_psw_mask to cpu.h)
30/37 Checking commit 590d47d41d9f (target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask)
31/37 Checking commit 58eccac108dd (target/s390x: Improve s390_cpu_dump_state vs cc_op)
32/37 Checking commit 635ee2fb75eb (target/s390x: Use s390_cpu_{set_psw, get_psw_mask} in gdbstub)
33/37 Checking commit b54d90b6745a (linux-user/s390x: Save and restore psw.mask properly)
34/37 Checking commit 4661ebe15ecc (s390x/css: Introduce an ESW struct)
35/37 Checking commit f8c61202ac40 (s390x/css: Split out the IRB sense data)
36/37 Checking commit 1cbff5a7ba83 (s390x/css: Refactor IRB construction)
37/37 Checking commit 89df28e4f545 (s390x/css: Add passthrough IRB)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210621095842.335162-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell June 22, 2021, 3:07 p.m. UTC | #2 
On Mon, 21 Jun 2021 at 10:58, Cornelia Huck <cohuck@redhat.com> wrote:
>
> The following changes since commit 8f521741e1280f0957ac1b873292c19219e1fb9a:
>
>   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210618.0' into staging (2021-06-18 16:42:25 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/cohuck/qemu.git tags/s390x-20210621
>
> for you to fetch changes up to c626710fc755628d0d6b88aab0514c9238a84522:
>
>   s390x/css: Add passthrough IRB (2021-06-21 08:48:21 +0200)
>
> ----------------------------------------------------------------
> s390x update:
> - tcg: implement the vector enhancements facility and bump the
>   'qemu' cpu model to a stripped-down z14 GA2
> - fix psw.mask handling in signals
> - fix vfio-ccw sense data handling
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.

-- PMM