[PULL,0/2] Audio 20210624 patches

Pull-request

git://git.kraxel.org/qemu tags/audio-20210624-pull-request

Message

Gerd Hoffmann June 24, 2021, 12:16 p.m. UTC

The following changes since commit b22726abdfa54592d6ad88f65b0297c0e8b363e2:

  Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging (2021-06-22 16:07:53 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/audio-20210624-pull-request

for you to fetch changes up to 60e543f5ce46d4a90a95963b3bab5c7d13a2aaa9:

  hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h (2021-06-24 11:42:54 +0200)

----------------------------------------------------------------
audio: bugfixes

----------------------------------------------------------------

Akihiko Odaki (1):
  coreaudio: Lock only the buffer

Qiang Liu (1):
  hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h

 audio/coreaudio.c            | 102 ++++++++++++++---------------------
 hw/audio/sb16.c              |  31 ++++++-----
 tests/qtest/fuzz-sb16-test.c |  17 ++++++
 3 files changed, 77 insertions(+), 73 deletions(-)

Comments

[e-mail] June 24, 2021, 12:21 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PULL 0/2] Audio 20210624 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
b397205 hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h
8b66bf4 coreaudio: Lock only the buffer

=== OUTPUT BEGIN ===
1/2 Checking commit 8b66bf451269 (coreaudio: Lock only the buffer)
ERROR: space prohibited between function name and open parenthesis '('
#61: FILE: audio/coreaudio.c:245:
+static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#66: FILE: audio/coreaudio.c:249:
+    err = pthread_mutex_lock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: audio/coreaudio.c:258:
+static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#80: FILE: audio/coreaudio.c:262:
+    err = pthread_mutex_unlock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#117: FILE: audio/coreaudio.c:314:
+    if (coreaudio_buf_lock (core, "audioDeviceIOProc")) {

ERROR: space prohibited between function name and open parenthesis '('
#124: FILE: audio/coreaudio.c:320:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(old device)");

ERROR: space prohibited between function name and open parenthesis '('
#133: FILE: audio/coreaudio.c:330:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(empty)");

ERROR: space prohibited between function name and open parenthesis '('
#142: FILE: audio/coreaudio.c:352:
+    coreaudio_buf_unlock (core, "audioDeviceIOProc");

total: 8 errors, 0 warnings, 237 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit b39720569bf6 (hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Peter Maydell June 28, 2021, 8:26 a.m. UTC | #2

On Thu, 24 Jun 2021 at 13:18, Gerd Hoffmann <[e-mail]> wrote:
>
> The following changes since commit b22726abdfa54592d6ad88f65b0297c0e8b363e2:
>
>   Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging (2021-06-22 16:07:53 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/audio-20210624-pull-request
>
> for you to fetch changes up to 60e543f5ce46d4a90a95963b3bab5c7d13a2aaa9:
>
>   hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h (2021-06-24 11:42:54 +0200)
>
> ----------------------------------------------------------------
> audio: bugfixes
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.

-- PMM