From patchwork Tue Jun 29 18:54:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 12350695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B017C11F67 for ; Tue, 29 Jun 2021 19:34:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 545F961DDE for ; Tue, 29 Jun 2021 19:34:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 545F961DDE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyJVP-0003j2-DQ for qemu-devel@archiver.kernel.org; Tue, 29 Jun 2021 15:34:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyIwe-0004A4-9f for qemu-devel@nongnu.org; Tue, 29 Jun 2021 14:58:53 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:39694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyIwP-00031u-Ja for qemu-devel@nongnu.org; Tue, 29 Jun 2021 14:58:52 -0400 Received: by mail-pj1-x1032.google.com with SMTP id in17-20020a17090b4391b0290170ba0ec7fcso2266518pjb.4 for ; Tue, 29 Jun 2021 11:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ziCUNw7iMfXxhXUy1AbaM+Ca/hJ3SGJZ/ldvQFuxiE8=; b=BrGLnNAb/Jj8veNGBmHqKQ+e/DVuU1bjAm8bnfpeN2r06visn9CZ6OqfrNV3FtJZi0 xIoRUWHsSPXDl02BD/H1MEPq+0xdvCDiXTiRbFXLARrPo55j+exgbtje4xV9zMiABA7z hOG2b5x3W7XTAsppnVFU6d5nCGu8VUo6YshOtZN8ulsFzJjfEBMfukNTUk2gvdYINLau qGDK5fryaDTIy4ZJktqRt2YJvos7G4OAul8RzydIA81eG0mc3JMJV4KNTcedOKpusEbZ ND7MkszDVgXxfCdY+E44RVADY8VhhreWoTz5vZGSj2qzXEGkPV70bjZknSVlLMzoIbL/ rQxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ziCUNw7iMfXxhXUy1AbaM+Ca/hJ3SGJZ/ldvQFuxiE8=; b=OEjuU7b8Iievz7FXkzoCLcCM4/dvPPYrUoIREplY39JBG1Ikw3I/uZTPLQ5eHCEJLA Ig5exUsvyWqf4Cg1AZZN955N0WUthW5xXNsHumEEawoM9EjdwP0YSbyZMXZt/CRLH46M onL99HM3a3bwfA3HvRfLnNyQQC2Oq0VCGZIRS0OPw95REySXt1vwwyujUlnVOTfQA4qF TAL66J26evbYbcRfnQo8Rym38VwYQLqKCYPUXX/9tNeGp2sr35C5YNrbjWJolbm2f7rr thjQ9+vRIKzrLT2Cc1HPT/w9DFHe23Vg+Ge6KEVxxB30ADfgV+3rSoGXoq/2rEFSuQTV 5OuQ== X-Gm-Message-State: AOAM532ed0TLg3aA8HbElwheIASRzvkVNsVRSVE3uOZMLbk8/cLUfoZa PAIGYjxOwgKUskxMJR8F3waybv51+S5ctQ== X-Google-Smtp-Source: ABdhPJzfCLnKlLDqcAjh18CnMCbQ9m9Goyldg8IpuGu7JXJtku0JBplRAyCale6/DhoXSq/tT0Inzw== X-Received: by 2002:a17:90a:f290:: with SMTP id fs16mr313256pjb.202.1624993115558; Tue, 29 Jun 2021 11:58:35 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id 21sm18002849pfh.103.2021.06.29.11.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 11:58:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 57/63] target/arm: Improve REVSH Date: Tue, 29 Jun 2021 11:54:49 -0700 Message-Id: <20210629185455.3131172-58-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210629185455.3131172-1-richard.henderson@linaro.org> References: <20210629185455.3131172-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The new bswap flags can implement the semantics exactly. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 669b0be578..a0c6cfa902 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -354,9 +354,7 @@ void gen_rev16(TCGv_i32 dest, TCGv_i32 var) /* Byteswap low halfword and sign extend. */ static void gen_revsh(TCGv_i32 dest, TCGv_i32 var) { - tcg_gen_ext16u_i32(var, var); - tcg_gen_bswap16_i32(var, var, TCG_BSWAP_IZ | TCG_BSWAP_OZ); - tcg_gen_ext16s_i32(dest, var); + tcg_gen_bswap16_i32(var, var, TCG_BSWAP_OS); } /* Dual 16-bit add. Result placed in t0 and t1 is marked as dead.