| Message ID | 20210702090935.15300-4-pl@kamp.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/rbd: migrate to coroutines and add write zeroes support | expand |
On Fri, Jul 2, 2021 at 11:09 AM Peter Lieven <pl@kamp.de> wrote: > > while at it just call rbd_get_size and avoid rbd_stat. > > Signed-off-by: Peter Lieven <pl@kamp.de> > --- > block/rbd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index b4caea4f1b..1f8dc84079 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -968,15 +968,14 @@ static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi) > static int64_t qemu_rbd_getlength(BlockDriverState *bs) > { > BDRVRBDState *s = bs->opaque; > - rbd_image_info_t info; > int r; > > - r = rbd_stat(s->image, &info, sizeof(info)); > + r = rbd_get_size(s->image, &s->image_size); > if (r < 0) { > return r; > } > > - return info.size; > + return s->image_size; > } > > static int coroutine_fn qemu_rbd_co_truncate(BlockDriverState *bs, > -- > 2.17.1 > > Reviewed-by: Ilya Dryomov <idryomov@gmail.com> Thanks, Ilya
diff --git a/block/rbd.c b/block/rbd.c index b4caea4f1b..1f8dc84079 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -968,15 +968,14 @@ static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi) static int64_t qemu_rbd_getlength(BlockDriverState *bs) { BDRVRBDState *s = bs->opaque; - rbd_image_info_t info; int r; - r = rbd_stat(s->image, &info, sizeof(info)); + r = rbd_get_size(s->image, &s->image_size); if (r < 0) { return r; } - return info.size; + return s->image_size; } static int coroutine_fn qemu_rbd_co_truncate(BlockDriverState *bs,
while at it just call rbd_get_size and avoid rbd_stat. Signed-off-by: Peter Lieven <pl@kamp.de> --- block/rbd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)