| Message ID | 20210707105324.23400-2-acho@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x cleanup | expand |
On 07/07/2021 12.53, Cho, Yu-Chen wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > Signed-off-by: Cho, Yu-Chen <acho@suse.com> > Acked-by: Cornelia Huck <cohuck@redhat.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target/s390x/meson.build b/target/s390x/meson.build > index c42eadb7d2..1219f64112 100644 > --- a/target/s390x/meson.build > +++ b/target/s390x/meson.build > @@ -58,5 +58,8 @@ if host_machine.cpu_family() == 's390x' and cc.has_link_argument('-Wl,--s390-pgs > if_true: declare_dependency(link_args: ['-Wl,--s390-pgste'])) > endif > > +s390x_user_ss = ss.source_set() > + > target_arch += {'s390x': s390x_ss} > target_softmmu_arch += {'s390x': s390x_softmmu_ss} > +target_user_arch += {'s390x': s390x_user_ss} > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Wed, Jul 07 2021, "Cho, Yu-Chen" <acho@suse.com> wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > Signed-off-by: Cho, Yu-Chen <acho@suse.com> Just noticed when I was sending a pull request: your unquoted name in the s-o-b confuses git send-email when it is doing its automatic cc:s (it adds a 'cc:Cho', which is obviously bogus and leads to the mail being rejected by the list server.) Not sure whether git send-email should add proper quoting itself, but putting quoting in the s-o-b line is probably a good idea (I'm wondering why git didn't add it in the first place.) Are you fine with me modifying your s-o-b lines in the commits to include quoting, if I need to resend the pull req? > Acked-by: Cornelia Huck <cohuck@redhat.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/meson.build | 3 +++ > 1 file changed, 3 insertions(+)
On Thu, 2021-07-08 at 19:20 +0200, Cornelia Huck wrote: > On Wed, Jul 07 2021, "Cho, Yu-Chen" <acho@suse.com> wrote: > > > the lack of target_user_arch makes it hard to fully leverage the > > build system in order to separate user code from sysemu code. > > > > Provide it, so that we can avoid the proliferation of #ifdef > > in target code. > > > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > > Signed-off-by: Cho, Yu-Chen <acho@suse.com> > > Just noticed when I was sending a pull request: your unquoted name in > the s-o-b confuses git send-email when it is doing its automatic cc:s > (it adds a 'cc:Cho', which is obviously bogus and leads to the mail > being rejected by the list server.) Not sure whether git send-email > should add proper quoting itself, but putting quoting in the s-o-b > line > is probably a good idea (I'm wondering why git didn't add it in the > first place.) > Not sure what happened here, but I didn't get any wrong from git send- email before. > Are you fine with me modifying your s-o-b lines in the commits to > include quoting, if I need to resend the pull req? > yes, please and thanks. Cheers, AL > > Acked-by: Cornelia Huck <cohuck@redhat.com> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > --- > > target/s390x/meson.build | 3 +++ > > 1 file changed, 3 insertions(+) >
On Fri, Jul 09 2021, Al Cho <ACho@suse.com> wrote: > On Thu, 2021-07-08 at 19:20 +0200, Cornelia Huck wrote: >> On Wed, Jul 07 2021, "Cho, Yu-Chen" <acho@suse.com> wrote: >> >> > the lack of target_user_arch makes it hard to fully leverage the >> > build system in order to separate user code from sysemu code. >> > >> > Provide it, so that we can avoid the proliferation of #ifdef >> > in target code. >> > >> > Signed-off-by: Claudio Fontana <cfontana@suse.de> >> > Signed-off-by: Cho, Yu-Chen <acho@suse.com> >> >> Just noticed when I was sending a pull request: your unquoted name in >> the s-o-b confuses git send-email when it is doing its automatic cc:s >> (it adds a 'cc:Cho', which is obviously bogus and leads to the mail >> being rejected by the list server.) Not sure whether git send-email >> should add proper quoting itself, but putting quoting in the s-o-b >> line >> is probably a good idea (I'm wondering why git didn't add it in the >> first place.) >> > > Not sure what happened here, but I didn't get any wrong from git send- > email before. It might do things differently for the author, depending on how you invoke it (at least the mails I see here look sane.) > >> Are you fine with me modifying your s-o-b lines in the commits to >> include quoting, if I need to resend the pull req? >> > > yes, please and thanks. Ok, I'll update them, if needed. > > Cheers, > AL > > >> > Acked-by: Cornelia Huck <cohuck@redhat.com> >> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> >> > --- >> > target/s390x/meson.build | 3 +++ >> > 1 file changed, 3 insertions(+) >>
diff --git a/target/s390x/meson.build b/target/s390x/meson.build index c42eadb7d2..1219f64112 100644 --- a/target/s390x/meson.build +++ b/target/s390x/meson.build @@ -58,5 +58,8 @@ if host_machine.cpu_family() == 's390x' and cc.has_link_argument('-Wl,--s390-pgs if_true: declare_dependency(link_args: ['-Wl,--s390-pgste'])) endif +s390x_user_ss = ss.source_set() + target_arch += {'s390x': s390x_ss} target_softmmu_arch += {'s390x': s390x_softmmu_ss} +target_user_arch += {'s390x': s390x_user_ss}