From patchwork Thu Jul 8 16:40:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 12365803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6D0C07E96 for ; Thu, 8 Jul 2021 17:23:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC17061874 for ; Thu, 8 Jul 2021 17:23:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC17061874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Xjy-0002eE-J2 for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 13:23:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1X5G-0001lu-93 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 12:41:06 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1X5B-0008CS-8m for qemu-devel@nongnu.org; Thu, 08 Jul 2021 12:41:05 -0400 Received: by mail-pg1-x533.google.com with SMTP id 62so6642582pgf.1 for ; Thu, 08 Jul 2021 09:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FItVyri6c20rZDoxu/jPzJDj0+JMz8PeBWfFEbYUUVs=; b=e93mRtznZXmVOpHDvcVPchAxvVEIhBCqAu3b/Npj77UqmDS9/QHWC4Y/j/buJIrxLI U6vUggHkxWV1N1fp0AhB14Z/Y4SN07Na38JuIMn997iFbkEzq3sjC4iWE0ugJTagzv9c lzEWlKksQeVLIYpHxC5DcXSEM2x6isuiHxak/pyHcZDKfLgdQTPlLWlClMbNLbRl30mh 2hs89epCLcSQlLP7IsJX+O0yivtfdRvtQR2YZgxDWG63EIukY7PuxUoVb28BTfHHZHFV tB75WhZYBSaLGjxL2Ei3X9DBDKgpGYCDZx1CXE7VGYJplG6xqsw872ALlgZ3ae3IM1oZ nmNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FItVyri6c20rZDoxu/jPzJDj0+JMz8PeBWfFEbYUUVs=; b=imTFuRUdfNLtPguncMU54rsawoCo90MlEFFvCpTOmvWEoMhcPgZkHaStgLYDr5esZC pLfyugYtQeYJHEQ385xEWImuO+wURBY7Hh8jZOAIq7LIrviIMKYTJMjwT110tYWQ1kcz U02LakWlMLBf3rum7M3b6aV+TchUUQIM/Gl/obL2w4AkcQgvqElf/COMQVsNXw+pbG8e qxy2TM02lKMvho/6mTbis1ojdsw5v0lC7y6dW+FfzkOEC8PTuEbspq8DGdeNZBhDQl4e OwK1D+z6MuHicIXJ9UJx9Atln5/san10rJ2e5n83jFKaj/Hug3Id3rNc/V1sYhP15Yhy O+Ag== X-Gm-Message-State: AOAM533+FI89Eqr6VAUstP3ejGL0svDbCNTV4ZJYPvM54MHissd+s8Ui nwKv2Tgy+p/vpqn8lAU9BZe+Ks+Wk6tnVA== X-Google-Smtp-Source: ABdhPJyqTx36v6qrrhTTInE63AMIWtRe6gdGTkHGxazrwUjMl18BnLMwEnl4Rr7q/QxkwTb6V/WNbg== X-Received: by 2002:a65:6145:: with SMTP id o5mr32872936pgv.410.1625762459868; Thu, 08 Jul 2021 09:40:59 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id j129sm3465678pfb.132.2021.07.08.09.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 09:40:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Date: Thu, 8 Jul 2021 09:40:38 -0700 Message-Id: <20210708164050.711967-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708164050.711967-1-richard.henderson@linaro.org> References: <20210708164050.711967-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Do not emit dead code for the singlestep_enabled case, after having exited the TB with a debug exception. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index f22d06952f..8e8f3858b6 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -4959,8 +4959,9 @@ static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) if (ctx->base.singlestep_enabled) { save_cpu_state(ctx, 0); gen_helper_raise_exception_debug(cpu_env); + } else { + tcg_gen_lookup_and_goto_ptr(); } - tcg_gen_lookup_and_goto_ptr(); } }