From patchwork Mon Jul 12 19:43:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12372071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDB5C07E9C for ; Mon, 12 Jul 2021 19:48:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7018661263 for ; Mon, 12 Jul 2021 19:48:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7018661263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m31v7-0008Ex-H7 for qemu-devel@archiver.kernel.org; Mon, 12 Jul 2021 15:48:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m31qZ-0001Zj-4D; Mon, 12 Jul 2021 15:44:07 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:38586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m31qV-0002fu-UA; Mon, 12 Jul 2021 15:44:06 -0400 Received: by mail-pl1-x631.google.com with SMTP id u3so4678584plf.5; Mon, 12 Jul 2021 12:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E+zrqjzPcvj6sVobiWzNXQ6kmh4zy9EjYGvkxkUwwDM=; b=XU4NN63CfYeuLLQ2kNYNuFznSLbaMRZ1rSPMhpuSTVd+5sbZM5ApiBKh5q7TgDko91 iyMt6z95XAYDNDhyyVJdI45Zx9r7F9NEueWpGSmuJfZ2Bx+heht774M6y6lHO6MQSqpr 4VPbJQoFL0WbCqF9rFTLowKwWSxjtrb0rtMI4f4TsjQqChcFvw3wiPv3pAuw59cURGMt 2tGLJ1oL1LCrwDz/sbjyPVV6wuJXd1cQmE9ZCx6lixcxUTBE1jZdMj1UnNQrompP/LcO rQDdO6dblpQ5Zv6nFFM9f3foTUMfYHAafooVbCKThrvI7rnGNvOO68S/EdISP9rOkkJx Speg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E+zrqjzPcvj6sVobiWzNXQ6kmh4zy9EjYGvkxkUwwDM=; b=Ub8/wl6JYt4g/YKtmbElD+fSxQI9lnYj6kf3BlLhTcBW5vuu/rzSVBOc+O9MHvByIC uex7yn/0vhTNdMZ5HSAn8ZQg7boaXYkOdbUGb7by+C16ddC3jJazTuCSgiFG9I2K0+a9 mbjSZBgQKatWKtionfCh0ZBs2JN2ypAqm/IacbcadxTwSM6FDu4ZHiB3+8QZi+QWWNtp Qxtz573FAJ2pUfNv2JaUX5PHPM5pmd/IzDY8y9DefsHa61TADOFtuJp9wSPrS+qD0Tyb GaiZUz7FxNdlSYaWVuquiuHPj3VWpToVxgMXgPhcMs/GE+uwdo1+9uZxoRvkJMNzzhrT Ni2g== X-Gm-Message-State: AOAM533zMYt38cdU/miJSlzR0NwwBPxULqZR+87PTlS5LZaxJCBYc32j 3Uw1eXrIgAoBgFAy2HlAw0TER3EzU8g= X-Google-Smtp-Source: ABdhPJyaaLe9D6OMfME9JSlN9YNGAck0Y2XSmKUF+BAUJC48ubvUbmdZ3qBpyxI+8oYGXMqJRSrC2w== X-Received: by 2002:a17:90a:a898:: with SMTP id h24mr2729111pjq.208.1626119039506; Mon, 12 Jul 2021 12:43:59 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c7:a7d9:90df:d3f0:78a8:2eb9]) by smtp.gmail.com with ESMTPSA id e21sm17075088pfc.172.2021.07.12.12.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 12:43:59 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v5 2/7] spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL Date: Mon, 12 Jul 2021 16:43:34 -0300 Message-Id: <20210712194339.813152-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210712194339.813152-1-danielhb413@gmail.com> References: <20210712194339.813152-1-danielhb413@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=danielhb413@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , armbru@redhat.com, groug@kaod.org, qemu-ppc@nongnu.org, eblake@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As done in hw/acpi/memory_hotplug.c, avoid sending qapi_event_send_mem_unplug_error() if dev->id is NULL. Suggested-by: Markus Armbruster Signed-off-by: Daniel Henrique Barboza Reviewed-by: Greg Kurz --- hw/ppc/spapr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 81699d4f8b..1611d7ab05 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3688,9 +3688,11 @@ void spapr_memory_unplug_rollback(SpaprMachineState *spapr, DeviceState *dev) * Tell QAPI that something happened and the memory * hotunplug wasn't successful. */ - qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest " - "for device %s", dev->id); - qapi_event_send_mem_unplug_error(dev->id, qapi_error); + if (dev->id) { + qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest " + "for device %s", dev->id); + qapi_event_send_mem_unplug_error(dev->id, qapi_error); + } } /* Callback to be called during DRC release. */