From patchwork Mon Jul 26 21:52:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kim, Dongwon" X-Patchwork-Id: 12400871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84DEC4338F for ; Mon, 26 Jul 2021 21:55:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 990D360F37 for ; Mon, 26 Jul 2021 21:55:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 990D360F37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m88ZQ-0004Tc-KU for qemu-devel@archiver.kernel.org; Mon, 26 Jul 2021 17:55:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m88YV-0002q9-Ri for qemu-devel@nongnu.org; Mon, 26 Jul 2021 17:54:35 -0400 Received: from mga18.intel.com ([134.134.136.126]:20211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m88YT-0001t6-69 for qemu-devel@nongnu.org; Mon, 26 Jul 2021 17:54:35 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10057"; a="199551418" X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="199551418" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 14:54:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="455897847" Received: from dw-tiger-lake-client-platform.fm.intel.com ([10.105.205.215]) by orsmga007.jf.intel.com with ESMTP; 26 Jul 2021 14:54:27 -0700 From: Dongwon Kim To: qemu-devel@nongnu.org Subject: [PATCH v2 1/2] ui/gtk: detach_all option for making all VCs detached upon starting Date: Mon, 26 Jul 2021 14:52:46 -0700 Message-Id: <20210726215246.26435-1-dongwon.kim@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210719214157.5863-1-dongwon.kim@intel.com> References: <20210719214157.5863-1-dongwon.kim@intel.com> Received-SPF: pass client-ip=134.134.136.126; envelope-from=dongwon.kim@intel.com; helo=mga18.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Khairul Anuar Romli , Dongwon Kim Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" With "detach-all=on" for display, all VCs are detached from the beginning. This is useful when there are multiple displays assigned to a guest OS. v2: Move "detach-all" option to under DisplayGTK as it's GTK specific (Thomas Huth) Signed-off-by: Dongwon Kim Signed-off-by: Khairul Anuar Romli --- qapi/ui.json | 5 ++++- ui/gtk.c | 7 +++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..e37af91683 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1035,13 +1035,16 @@ # assuming the guest will resize the display to match # the window size then. Otherwise it defaults to "off". # Since 3.1 +# @detach-all: Detach all VirtualConsoles when starting Qemu (default: off). +# Since 6.0 # # Since: 2.12 # ## { 'struct' : 'DisplayGTK', 'data' : { '*grab-on-hover' : 'bool', - '*zoom-to-fit' : 'bool' } } + '*zoom-to-fit' : 'bool', + '*detach-all' : 'bool' } } ## # @DisplayEGLHeadless: diff --git a/ui/gtk.c b/ui/gtk.c index 98046f577b..48c1fff54f 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -2189,6 +2189,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts) GdkDisplay *window_display; GtkIconTheme *theme; char *dir; + int i; if (!gtkinit) { fprintf(stderr, "gtk initialization failed\n"); @@ -2268,6 +2269,12 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts) gtk_menu_item_activate(GTK_MENU_ITEM(s->grab_on_hover_item)); } gd_clipboard_init(s); + + if (opts->u.gtk.detach_all) { + for (i = 0; i < s->nb_vcs - 1; i++) { + gtk_menu_item_activate(GTK_MENU_ITEM(s->untabify_item)); + } + } } static void early_gtk_display_init(DisplayOptions *opts)