[for-6.2,3/6] s390-sclp-events-bus: Set instance_size

Commit Message

Eduardo Habkost Aug. 5, 2021, 7:34 p.m. UTC

We have a SCLPEventsBus struct defined, but the struct is not
used at the TypeInfo definition.  This works today but will break
silently if anybody adds a new field to SCLPEventsBus.

Set instance_size properly to avoid problems in the future.

Signed-off-by: Eduardo Habkost <[e-mail]>
---
Cc: Cornelia Huck <[e-mail]>
Cc: Thomas Huth <[e-mail]>
Cc: Halil Pasic <[e-mail]>
Cc: Christian Borntraeger <[e-mail]>
Cc: Richard Henderson <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
---
 hw/s390x/event-facility.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth Aug. 6, 2021, 4:16 a.m. UTC | #1

On 05/08/2021 21.34, Eduardo Habkost wrote:
> We have a SCLPEventsBus struct defined, but the struct is not
> used at the TypeInfo definition.  This works today but will break
> silently if anybody adds a new field to SCLPEventsBus.
> 
> Set instance_size properly to avoid problems in the future.
> 
> Signed-off-by: Eduardo Habkost <[e-mail]>
> ---
> Cc: Cornelia Huck <[e-mail]>
> Cc: Thomas Huth <[e-mail]>
> Cc: Halil Pasic <[e-mail]>
> Cc: Christian Borntraeger <[e-mail]>
> Cc: Richard Henderson <[e-mail]>
> Cc: David Hildenbrand <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>   hw/s390x/event-facility.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index ed92ce510d9..0a65e16cdd9 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -332,6 +332,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb)
>   static const TypeInfo sclp_events_bus_info = {
>       .name = TYPE_SCLP_EVENTS_BUS,
>       .parent = TYPE_BUS,
> +    .instance_size = sizeof(SCLPEventsBus),
>   };
>   
>   static void command_handler(SCLPEventFacility *ef, SCCB *sccb, uint64_t code)
> 

Reviewed-by: Thomas Huth <[e-mail]>

David Hildenbrand Aug. 6, 2021, 6:54 a.m. UTC | #2

On 05.08.21 21:34, Eduardo Habkost wrote:
> We have a SCLPEventsBus struct defined, but the struct is not
> used at the TypeInfo definition.  This works today but will break
> silently if anybody adds a new field to SCLPEventsBus.
> 
> Set instance_size properly to avoid problems in the future.
> 
> Signed-off-by: Eduardo Habkost <[e-mail]>
> ---
> Cc: Cornelia Huck <[e-mail]>
> Cc: Thomas Huth <[e-mail]>
> Cc: Halil Pasic <[e-mail]>
> Cc: Christian Borntraeger <[e-mail]>
> Cc: Richard Henderson <[e-mail]>
> Cc: David Hildenbrand <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>   hw/s390x/event-facility.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index ed92ce510d9..0a65e16cdd9 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -332,6 +332,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb)
>   static const TypeInfo sclp_events_bus_info = {
>       .name = TYPE_SCLP_EVENTS_BUS,
>       .parent = TYPE_BUS,
> +    .instance_size = sizeof(SCLPEventsBus),
>   };
>   
>   static void command_handler(SCLPEventFacility *ef, SCCB *sccb, uint64_t code)
> 

Reviewed-by: David Hildenbrand <[e-mail]>

Cornelia Huck Aug. 6, 2021, 11:44 a.m. UTC | #3

On Thu, Aug 05 2021, Eduardo Habkost <[e-mail]> wrote:

> We have a SCLPEventsBus struct defined, but the struct is not
> used at the TypeInfo definition.  This works today but will break
> silently if anybody adds a new field to SCLPEventsBus.
>
> Set instance_size properly to avoid problems in the future.
>
> Signed-off-by: Eduardo Habkost <[e-mail]>
> ---
> Cc: Cornelia Huck <[e-mail]>
> Cc: Thomas Huth <[e-mail]>
> Cc: Halil Pasic <[e-mail]>
> Cc: Christian Borntraeger <[e-mail]>
> Cc: Richard Henderson <[e-mail]>
> Cc: David Hildenbrand <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  hw/s390x/event-facility.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Cornelia Huck <[e-mail]>

(I assume that you'll queue the whole series yourself? Or should we pick
the s390x parts separately?)

Patch

diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index ed92ce510d9..0a65e16cdd9 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -332,6 +332,7 @@  static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb)
 static const TypeInfo sclp_events_bus_info = {
     .name = TYPE_SCLP_EVENTS_BUS,
     .parent = TYPE_BUS,
+    .instance_size = sizeof(SCLPEventsBus),
 };
 
 static void command_handler(SCLPEventFacility *ef, SCCB *sccb, uint64_t code)