From patchwork Wed Aug 25 00:48:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12456127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8A1C4338F for ; Wed, 25 Aug 2021 00:52:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6319B61176 for ; Wed, 25 Aug 2021 00:52:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6319B61176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIh9w-0000X6-Ip for qemu-devel@archiver.kernel.org; Tue, 24 Aug 2021 20:52:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIh6G-0001cV-2Z; Tue, 24 Aug 2021 20:49:05 -0400 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]:33675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIh6E-0006xi-1P; Tue, 24 Aug 2021 20:49:03 -0400 Received: by mail-qv1-xf2b.google.com with SMTP id a5so4710809qvq.0; Tue, 24 Aug 2021 17:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T5goQIXIwtMNfeSBsrGH+6jpx4dotCpOid1Vqn34LKQ=; b=VwEmMuiFb1OkzCaVA/XUPkwP+hoCyTkDcgYR9CoMsJmW/SKIpuykowCy5csG5Wmgxp m7I9942rbkT2S2ctxClqkBQaaiKvh4eP3NP0n8l8KYbiPHT7ZJNkEl6mDvImFvs7p0DB oKtSpgqGLFQqQgGgW8yApqggFu5rhtBbM3A7vNiJDm7Jr/UEtosxtBg6qjwDZRQh+npN yIuuaUCZT72CoKRscD0BLS5CUiBIQIdHiS/zvYUDOmsnV19Pccf61K3cEUreLE5QseY9 /EHXn5UVBjVlQhbdiLAYw33qZLOQr3sS9Mbmx0VFzYie1wHue9f3ol/aG2/OlGQJrq9M qgoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5goQIXIwtMNfeSBsrGH+6jpx4dotCpOid1Vqn34LKQ=; b=lEcfT0OyzhFSVYSDiUWx8eAx+QYut+xFF/JoHBvvUY9wHo9DgdLIp0cjjyRgDviwne MjILUSgSk6Tbau8o3d5szLFbhMNfqrDmUE107epqG3KXG17NP9cb95u0XzTC0/rSiNuR Sk3ZdN+U11ewpVEuvRVky919ehkxaWuG+95PPZJPoMqueobKsM4NRScvRoAn7TbbAPTf aVVgU0EZqecrJBapgTe4UWunRxbw+GzDPjWYwIjkuaLQDggGnC7B9cq8GasF3yiCicLd FfGHnRAyXi8yC1bM4WcKXcdznnDsjZhSQLifZQ8OQ0BSZaSPt5Wvn28Ggkd6vdLS5/VW iHNA== X-Gm-Message-State: AOAM531KKxF0H8jQEvTiKIQhMHOkdZNwQ/U8Q/dW4X0XsogH4tDvvz07 Ln2KZWMkG8UWkCb4HijlD0Owj7AZx0M= X-Google-Smtp-Source: ABdhPJxgsdt9tFc7VwON4QYimYAOqG3u9NYsn54BLIGmXHDiBY8e4njL4YTj/jXXYFDwiei6E5w9nA== X-Received: by 2002:a0c:e5ce:: with SMTP id u14mr17902818qvm.15.1629852540579; Tue, 24 Aug 2021 17:49:00 -0700 (PDT) Received: from rekt.ihost.com ([179.247.162.205]) by smtp.gmail.com with ESMTPSA id x10sm1515266qto.41.2021.08.24.17.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 17:49:00 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback() Date: Tue, 24 Aug 2021 21:48:30 -0300 Message-Id: <20210825004835.472919-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210825004835.472919-1-danielhb413@gmail.com> References: <20210825004835.472919-1-danielhb413@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::f2b; envelope-from=danielhb413@gmail.com; helo=mail-qv1-xf2b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, Daniel Henrique Barboza , qemu-ppc@nongnu.org, groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id is NULL to qapi_event_send_mem_unplug_error() to avoid relying on a behavior that can be changed in the future. Suggested-by: Markus Armbruster Signed-off-by: Daniel Henrique Barboza Reviewed-by: David Gibson Reviewed-by: Greg Kurz --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 81699d4f8b..4f1ee90e9e 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3690,7 +3690,7 @@ void spapr_memory_unplug_rollback(SpaprMachineState *spapr, DeviceState *dev) */ qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest " "for device %s", dev->id); - qapi_event_send_mem_unplug_error(dev->id, qapi_error); + qapi_event_send_mem_unplug_error(dev->id ? : "", qapi_error); } /* Callback to be called during DRC release. */