[v2,04/11] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

Commit Message

Philippe Mathieu-Daudé Aug. 26, 2021, 7:50 p.m. UTC

qemu_vfio_add_mapping() returns a pointer to an indexed entry
in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL.
Remove the pointless check.

Reviewed-by: Klaus Jensen <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 util/vfio-helpers.c | 4 ----
 1 file changed, 4 deletions(-)

Patch

diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
index d956866b4e9..e7909222cfd 100644
--- a/util/vfio-helpers.c
+++ b/util/vfio-helpers.c
@@ -751,10 +751,6 @@  int qemu_vfio_dma_map(QEMUVFIOState *s, void *host, size_t size,
             }
 
             mapping = qemu_vfio_add_mapping(s, host, size, index + 1, iova0);
-            if (!mapping) {
-                ret = -ENOMEM;
-                goto out;
-            }
             assert(qemu_vfio_verify_mappings(s));
             ret = qemu_vfio_do_mapping(s, host, size, iova0);
             if (ret) {