From patchwork Sat Sep 4 20:35:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 12475827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A432EC433FE for ; Sat, 4 Sep 2021 20:41:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51B4760C3E for ; Sat, 4 Sep 2021 20:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 51B4760C3E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMcU9-00014I-6N for qemu-devel@archiver.kernel.org; Sat, 04 Sep 2021 16:41:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMcNv-0005wD-SF for qemu-devel@nongnu.org; Sat, 04 Sep 2021 16:35:32 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:47008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMcNo-0002qV-2k for qemu-devel@nongnu.org; Sat, 04 Sep 2021 16:35:29 -0400 Received: by mail-lf1-x135.google.com with SMTP id t19so5304391lfe.13 for ; Sat, 04 Sep 2021 13:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+RYgb2Yyt+iByrgIUPc6oLOtmbpHlp17f5Zuux7SRC8=; b=0BvrqpScmpgXfBj7jy0/Gjn22M72ZwAYQuQK2V+ipVi8HQKSKm2cMo52Rou8dX4t1u Tmc+aV80U2FQOQ6I/dVkCreUsg6zb69XrooqZGdLUrUu3eNfiFQpMbBMzRwHNbzXGZZw yvFsmwROrd1ZVTy6BB63EGmN/kd1UYOXEEiKn+/WpLnJpeICj1UGWsX0gkMVhclrb79J lMuZtInJz4zNRtugNKlfrXVAZncK+NYCNkZsw177h+hgGTPvwmJab0WKoibXMFsn2VNb kRFavxA3N/cuAHyBnTNUzyvIbzu/iT36Ro37/CxnLsCAN4cHKglt+oO4ARWX/mu5fosm XRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+RYgb2Yyt+iByrgIUPc6oLOtmbpHlp17f5Zuux7SRC8=; b=QKyul8o1L/8Bq103ahSuuqnyKRBs3Bb5bJ6zY1YRmutIHsRblrTH9SZRpJqUWpeBxx i/45o91GAz3wRMtma+NolXw9b61hfj5nfG5nNnPD5WklSgQMaIkxSLoS1N8M5CA94/Ly S1/9bFFSbQRzqbWsmpnMSe7UYAO/BwSOIgbj4ven66ohmgtjLvbIk3GUYwozF50B8Xrv KfqMANv4HbVjbaMxbW9vn53yt5xwiXj9oiDEjq7xE8XmECppGg1YJcHhpwTzHs0jBG1B ZuuE+14jXABONSQLipQxqzvkjpBNvHlj08by+4jqeTyVg8Ur0vo9K3WDdTXx9v7UyOyO HL8w== X-Gm-Message-State: AOAM530z8qHWlqYMm3B4fSTUdznh0WN+Nb68KoYyPTWLZ08v99cqhwlW gnlt7b/od/mfSrmHvrro4fWjtZ/lkiTvzZ/Hfi4= X-Google-Smtp-Source: ABdhPJwTMxF1mDJmevj6Aie8+ol8seBsy5YKyAIfC2nSir0eB6otGXUxXVRbt8+BdrLIzAZUE1OHaw== X-Received: by 2002:a05:6512:3096:: with SMTP id z22mr4078856lfd.475.1630787720287; Sat, 04 Sep 2021 13:35:20 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:3a:1e26::2]) by smtp.gmail.com with ESMTPSA id v15sm326304lfq.142.2021.09.04.13.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 13:35:20 -0700 (PDT) From: Philipp Tomsich To: qemu-devel@nongnu.org Subject: [PATCH v10 01/16] target/riscv: Introduce temporary in gen_add_uw() Date: Sat, 4 Sep 2021 22:35:00 +0200 Message-Id: <20210904203516.2570119-2-philipp.tomsich@vrull.eu> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210904203516.2570119-1-philipp.tomsich@vrull.eu> References: <20210904203516.2570119-1-philipp.tomsich@vrull.eu> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=philipp.tomsich@vrull.eu; helo=mail-lf1-x135.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Kito Cheng , Alistair Francis , Philipp Tomsich Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Following the recent changes in translate.c, gen_add_uw() causes failures on CF3 and SPEC2017 due to the reuse of arg1. Fix these regressions by introducing a temporary. Signed-off-by: Philipp Tomsich Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- Changes in v10: - new patch target/riscv/insn_trans/trans_rvb.c.inc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index b72e76255c..c0a6e25826 100644 --- a/target/riscv/insn_trans/trans_rvb.c.inc +++ b/target/riscv/insn_trans/trans_rvb.c.inc @@ -624,8 +624,10 @@ GEN_TRANS_SHADD_UW(3) static void gen_add_uw(TCGv ret, TCGv arg1, TCGv arg2) { - tcg_gen_ext32u_tl(arg1, arg1); - tcg_gen_add_tl(ret, arg1, arg2); + TCGv t = tcg_temp_new(); + tcg_gen_ext32u_tl(t, arg1); + tcg_gen_add_tl(ret, t, arg2); + tcg_temp_free(t); } static bool trans_add_uw(DisasContext *ctx, arg_add_uw *a)