| Message ID | 20210914115157.35868-1-quintela@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 14 Sept 2021 at 12:56, Juan Quintela <quintela@redhat.com> wrote: > > The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git tags/migration.next-pull-request > > for you to fetch changes up to d634d0e7b0225f97f45cecb72ca90bd0e7bdb211: > > migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() (2021-09-14 13:45:06 +0200) > > ---------------------------------------------------------------- > Migration Pull request (take 2) > > This pull request includes: > - Remove RAMState unused parameter for several prototypes (dropped) > - RDMA fix > - give an error when using RDMA and multifd > - Implement yank for multifd send side > > Please, Apply. > Hi; this fails to build on FreeBSD: ../src/migration/rdma.c:1146:23: error: use of undeclared identifier 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE' int advice = wr ? IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE : ^ ../src/migration/rdma.c:1147:18: error: use of undeclared identifier 'IBV_ADVISE_MR_ADVICE_PREFETCH' IBV_ADVISE_MR_ADVICE_PREFETCH; ^ ../src/migration/rdma.c:1150:11: warning: implicit declaration of function 'ibv_advise_mr' is invalid in C99 [-Wimplicit-function-declaration] ret = ibv_advise_mr(pd, advice, ^ ../src/migration/rdma.c:1151:25: error: use of undeclared identifier 'IBV_ADVISE_MR_FLAG_FLUSH' IBV_ADVISE_MR_FLAG_FLUSH, &sg_list, 1); ^ 1 warning and 3 errors generated. Looking at the code, none of the proposed ways to detect whether the host has this function seem to have been implemented: did you push the wrong branch ? thanks -- PMM
on 2021/9/14 21:19, Peter Maydell wrote: > On Tue, 14 Sept 2021 at 12:56, Juan Quintela <quintela@redhat.com> wrote: >> The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: >> >> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) >> >> are available in the Git repository at: >> >> https://github.com/juanquintela/qemu.git tags/migration.next-pull-request >> >> for you to fetch changes up to d634d0e7b0225f97f45cecb72ca90bd0e7bdb211: >> >> migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() (2021-09-14 13:45:06 +0200) >> >> ---------------------------------------------------------------- >> Migration Pull request (take 2) >> >> This pull request includes: >> - Remove RAMState unused parameter for several prototypes (dropped) >> - RDMA fix >> - give an error when using RDMA and multifd >> - Implement yank for multifd send side >> >> Please, Apply. >> > Hi; this fails to build on FreeBSD: > > ../src/migration/rdma.c:1146:23: error: use of undeclared identifier > 'IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE' > int advice = wr ? IBV_ADVISE_MR_ADVICE_PREFETCH_WRITE : > ^ > ../src/migration/rdma.c:1147:18: error: use of undeclared identifier > 'IBV_ADVISE_MR_ADVICE_PREFETCH' > IBV_ADVISE_MR_ADVICE_PREFETCH; > ^ > ../src/migration/rdma.c:1150:11: warning: implicit declaration of > function 'ibv_advise_mr' is invalid in C99 > [-Wimplicit-function-declaration] > ret = ibv_advise_mr(pd, advice, > ^ > ../src/migration/rdma.c:1151:25: error: use of undeclared identifier > 'IBV_ADVISE_MR_FLAG_FLUSH' > IBV_ADVISE_MR_FLAG_FLUSH, &sg_list, 1); > ^ > 1 warning and 3 errors generated. > > Looking at the code, none of the proposed ways to detect > whether the host has this function seem to have been implemented: > did you push the wrong branch ? Yes, this errors should be fixed in my V3 patches: [PATCH v3 0/2] enable fsdax rdma migration And i recalled that the 1st pull request included 7 patches, 2 are deleted in this time? Thanks Zhijina > > thanks > -- PMM >
The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migration.next-pull-request for you to fetch changes up to d634d0e7b0225f97f45cecb72ca90bd0e7bdb211: migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() (2021-09-14 13:45:06 +0200) ---------------------------------------------------------------- Migration Pull request (take 2) This pull request includes: - Remove RAMState unused parameter for several prototypes (dropped) - RDMA fix - give an error when using RDMA and multifd - Implement yank for multifd send side Please, Apply. ---------------------------------------------------------------- David Hildenbrand (1): migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() Li Zhijian (2): migration/rdma: Try to register On-Demand Paging memory region migration/rdma: advise prefetch write for ODP region Lukas Straub (2): multifd: Implement yank for multifd send side multifd: Unconditionally unregister yank function migration/multifd.h | 2 + migration/multifd.c | 11 ++-- migration/ram.c | 13 ++--- migration/rdma.c | 111 ++++++++++++++++++++++++++++++++++------- migration/trace-events | 2 + 5 files changed, 107 insertions(+), 32 deletions(-)