| Message ID | 20210929130316.121330-1-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/sh4: Use lookup_symbol in sh4_tr_disas_log | expand |
On 9/29/21 15:03, Richard Henderson wrote: > The correct thing to do has been present but commented > out since the initial commit of the sh4 translator. > > Fixes: fdf9b3e831e > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/sh4/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Le 29/09/2021 à 15:03, Richard Henderson a écrit : > The correct thing to do has been present but commented > out since the initial commit of the sh4 translator. > > Fixes: fdf9b3e831e > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/sh4/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/sh4/translate.c b/target/sh4/translate.c > index cf5fe9243d..d363050272 100644 > --- a/target/sh4/translate.c > +++ b/target/sh4/translate.c > @@ -2344,7 +2344,7 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) > > static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) > { > - qemu_log("IN:\n"); /* , lookup_symbol(dcbase->pc_first)); */ > + qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); > log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); > } > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/target/sh4/translate.c b/target/sh4/translate.c index cf5fe9243d..d363050272 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -2344,7 +2344,7 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) { - qemu_log("IN:\n"); /* , lookup_symbol(dcbase->pc_first)); */ + qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); }
The correct thing to do has been present but commented out since the initial commit of the sh4 translator. Fixes: fdf9b3e831e Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/sh4/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)