diff mbox series

[PULL,v2,02/15] block/aio_task: assert `max_busy_tasks` is greater than 0

Message ID 20211007153904.445009-3-vsementsov@virtuozzo.com (mailing list archive)
State New, archived
Headers show
Series [PULL,v2,01/15] block/backup: avoid integer overflow of `max-workers` | expand

Commit Message

Vladimir Sementsov-Ogievskiy Oct. 7, 2021, 3:39 p.m. UTC 
From: Stefano Garzarella <sgarzare@redhat.com>

All code in block/aio_task.c expects `max_busy_tasks` to always
be greater than 0.

Assert this condition during the AioTaskPool creation where
`max_busy_tasks` is set.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20211005161157.282396-3-sgarzare@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/aio_task.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/block/aio_task.c b/block/aio_task.c
index 88989fa248..9bd17ea2c1 100644
--- a/block/aio_task.c
+++ b/block/aio_task.c
@@ -98,6 +98,8 @@  AioTaskPool *coroutine_fn aio_task_pool_new(int max_busy_tasks)
 {
     AioTaskPool *pool = g_new0(AioTaskPool, 1);
 
+    assert(max_busy_tasks > 0);
+
     pool->main_co = qemu_coroutine_self();
     pool->max_busy_tasks = max_busy_tasks;