| Message ID | 20211019164447.16359-18-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bsd-user: arm (32-bit) support | expand |
On Tue, Oct 19, 2021 at 11:45 AM Warner Losh <imp@bsdimp.com> wrote: > > Defines for registers and stack layout related to signals. > > Signed-off-by: Stacey Son <sson@FreeBSD.org> > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/arm/target_arch_signal.h | 57 +++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 bsd-user/arm/target_arch_signal.h > > diff --git a/bsd-user/arm/target_arch_signal.h b/bsd-user/arm/target_arch_signal.h > new file mode 100644 > index 0000000000..973183d99c > --- /dev/null > +++ b/bsd-user/arm/target_arch_signal.h > @@ -0,0 +1,57 @@ > +/* > + * arm signal definitions > + * > + * Copyright (c) 2013 Stacey D. Son > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > +#ifndef _TARGET_ARCH_SIGNAL_H_ > +#define _TARGET_ARCH_SIGNAL_H_ > + > +#include "cpu.h" > + > +#define TARGET_REG_R0 0 > +#define TARGET_REG_R1 1 > +#define TARGET_REG_R2 2 > +#define TARGET_REG_R3 3 > +#define TARGET_REG_R4 4 > +#define TARGET_REG_R5 5 > +#define TARGET_REG_R6 6 > +#define TARGET_REG_R7 7 > +#define TARGET_REG_R8 8 > +#define TARGET_REG_R9 9 > +#define TARGET_REG_R10 10 > +#define TARGET_REG_R11 11 > +#define TARGET_REG_R12 12 > +#define TARGET_REG_R13 13 > +#define TARGET_REG_R14 14 > +#define TARGET_REG_R15 15 > +#define TARGET_REG_CPSR 16 > +#define TARGET__NGREG 17 > +/* Convenience synonyms */ > +#define TARGET_REG_FP TARGET_REG_R11 > +#define TARGET_REG_SP TARGET_REG_R13 > +#define TARGET_REG_LR TARGET_REG_R14 > +#define TARGET_REG_PC TARGET_REG_R15 > + > +#define TARGET_INSN_SIZE 4 /* arm instruction size */ > + > +/* Size of the signal trampolin code. See _sigtramp(). */ > +#define TARGET_SZSIGCODE ((abi_ulong)(9 * TARGET_INSN_SIZE)) > + > +/* compare to arm/include/_limits.h */ > +#define TARGET_MINSIGSTKSZ (1024 * 4) /* min sig stack size */ > +#define TARGET_SIGSTKSZ (TARGET_MINSIGSTKSZ + 32768) /* recommended size */ > + > +#endif /* !_TARGET_ARCH_SIGNAL_H_ */ > -- > 2.32.0 > Reviewed-by: Kyle Evans <kevans@FreeBSD.org>
On 10/19/21 9:44 AM, Warner Losh wrote: > +#define TARGET_INSN_SIZE 4 /* arm instruction size */ What is this for? arm max insn size? Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Thu, Oct 28, 2021 at 10:18 AM Richard Henderson < richard.henderson@linaro.org> wrote: > On 10/19/21 9:44 AM, Warner Losh wrote: > > +#define TARGET_INSN_SIZE 4 /* arm instruction size */ > > What is this for? arm max insn size? > It's used a few lines below: +#define TARGET_SZSIGCODE ((abi_ulong)(9 * TARGET_INSN_SIZE)) which is a fancy way of getting the sizeof the sigtramp handler that's copied onto the stack and used in the setup. It's then used in bsd-user/arm/target_arch_signal.h because it doesn't have visibility to target_arch_sigtramp.h's namespace to get the size. It's likely a 'todo' cleanup to make this less hard-coded. Warner > Otherwise, > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > r~ >
diff --git a/bsd-user/arm/target_arch_signal.h b/bsd-user/arm/target_arch_signal.h new file mode 100644 index 0000000000..973183d99c --- /dev/null +++ b/bsd-user/arm/target_arch_signal.h @@ -0,0 +1,57 @@ +/* + * arm signal definitions + * + * Copyright (c) 2013 Stacey D. Son + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see <http://www.gnu.org/licenses/>. + */ +#ifndef _TARGET_ARCH_SIGNAL_H_ +#define _TARGET_ARCH_SIGNAL_H_ + +#include "cpu.h" + +#define TARGET_REG_R0 0 +#define TARGET_REG_R1 1 +#define TARGET_REG_R2 2 +#define TARGET_REG_R3 3 +#define TARGET_REG_R4 4 +#define TARGET_REG_R5 5 +#define TARGET_REG_R6 6 +#define TARGET_REG_R7 7 +#define TARGET_REG_R8 8 +#define TARGET_REG_R9 9 +#define TARGET_REG_R10 10 +#define TARGET_REG_R11 11 +#define TARGET_REG_R12 12 +#define TARGET_REG_R13 13 +#define TARGET_REG_R14 14 +#define TARGET_REG_R15 15 +#define TARGET_REG_CPSR 16 +#define TARGET__NGREG 17 +/* Convenience synonyms */ +#define TARGET_REG_FP TARGET_REG_R11 +#define TARGET_REG_SP TARGET_REG_R13 +#define TARGET_REG_LR TARGET_REG_R14 +#define TARGET_REG_PC TARGET_REG_R15 + +#define TARGET_INSN_SIZE 4 /* arm instruction size */ + +/* Size of the signal trampolin code. See _sigtramp(). */ +#define TARGET_SZSIGCODE ((abi_ulong)(9 * TARGET_INSN_SIZE)) + +/* compare to arm/include/_limits.h */ +#define TARGET_MINSIGSTKSZ (1024 * 4) /* min sig stack size */ +#define TARGET_SIGSTKSZ (TARGET_MINSIGSTKSZ + 32768) /* recommended size */ + +#endif /* !_TARGET_ARCH_SIGNAL_H_ */