| Message ID | 20211111153354.18807-11-rvkagan@yandex-team.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vhost: stick to -errno error return convention | expand |
Ditto - not for 6.2. I'm happy with this once the vhost and vhost-user patches go in. Looks like vhost-user-vgpu, vhost-user-input and vhost-user-vsock also return -1 on vhost_user_*_handle_config_change, so presumably those should be fixed too. On Thu, Nov 11, 2021 at 06:33:54PM +0300, Roman Kagan wrote: > Fix the only callsite that doesn't propagate the error code from the > generic vhost code. > > Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru> > --- Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com> > hw/block/vhost-user-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > index f9b17f6813..ab11ce8252 100644 > --- a/hw/block/vhost-user-blk.c > +++ b/hw/block/vhost-user-blk.c > @@ -100,7 +100,7 @@ static int vhost_user_blk_handle_config_change(struct vhost_dev *dev) > &local_err); > if (ret < 0) { > error_report_err(local_err); > - return -1; > + return ret; > } > > /* valid for resize only */ > -- > 2.33.1 >
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index f9b17f6813..ab11ce8252 100644 --- a/hw/block/vhost-user-blk.c +++ b/hw/block/vhost-user-blk.c @@ -100,7 +100,7 @@ static int vhost_user_blk_handle_config_change(struct vhost_dev *dev) &local_err); if (ret < 0) { error_report_err(local_err); - return -1; + return ret; } /* valid for resize only */
Fix the only callsite that doesn't propagate the error code from the generic vhost code. Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru> --- hw/block/vhost-user-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)