From patchwork Mon Nov 22 12:40:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 12631857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D222FC433EF for ; Mon, 22 Nov 2021 12:53:21 +0000 (UTC) Received: from localhost ([::1]:56766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mp8oz-0000we-02 for qemu-devel@archiver.kernel.org; Mon, 22 Nov 2021 07:53:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp8eO-0005eB-8a for qemu-devel@nongnu.org; Mon, 22 Nov 2021 07:42:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp8eM-0000SW-Ec for qemu-devel@nongnu.org; Mon, 22 Nov 2021 07:42:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637584941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GO6Cf+oYPuEAdZYlyCQcLQGlYrS0+VewS+fPf2+wz+I=; b=CSWm5HyHJyw1q7IfFn6BnTPWUJ22rHuNipAUZtyh/Mo9stAEQEEDZGvb/UKYVCaPLTkpYi 7Qe4vTZr6OUneLJa7/JzsdjNDi6MVIxKyR3bwG2RG7eq2L+s0+R3Was2rqkAkPExOCA7bH xBGu3TbpOGt/czKCxUK8sWOcwtOn6gs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-301-DSIAELzkM5umyDzpA_UaMA-1; Mon, 22 Nov 2021 07:42:18 -0500 X-MC-Unique: DSIAELzkM5umyDzpA_UaMA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 314B48066EC; Mon, 22 Nov 2021 12:42:17 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE111ADCD; Mon, 22 Nov 2021 12:42:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A04AD1800939; Mon, 22 Nov 2021 13:40:15 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 8/8] microvm: check g_file_set_contents() return value Date: Mon, 22 Nov 2021 13:40:15 +0100 Message-Id: <20211122124015.909318-9-kraxel@redhat.com> In-Reply-To: <20211122124015.909318-1-kraxel@redhat.com> References: <20211122124015.909318-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.709, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , Gerd Hoffmann , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fixes: CID 1465239 Signed-off-by: Gerd Hoffmann Message-Id: <20211108130718.840216-3-kraxel@redhat.com> --- hw/i386/microvm-dt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c index a6a59a6e12cd..9c3c4995b41d 100644 --- a/hw/i386/microvm-dt.c +++ b/hw/i386/microvm-dt.c @@ -336,7 +336,10 @@ void dt_setup_microvm(MicrovmMachineState *mms) if (debug) { fprintf(stderr, "%s: writing microvm.fdt\n", __func__); - g_file_set_contents("microvm.fdt", mms->fdt, size, NULL); + if (!g_file_set_contents("microvm.fdt", mms->fdt, size, NULL)) { + fprintf(stderr, "%s: writing microvm.fdt failed\n", __func__); + return; + } int ret = system("dtc -I dtb -O dts microvm.fdt"); if (ret != 0) { fprintf(stderr, "%s: oops, dtc not installed?\n", __func__);