Message ID | 20211210080659.2537084-1-kraxel@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | uas: add missing return | expand |
On 12/10/21 09:06, Gerd Hoffmann wrote: > Otherwise we run the error handling code even for successful requests. > > Fixes: 13b250b12ad3 ("uas: add stream number sanity checks.") > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > hw/usb/dev-uas.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 599d6b52a012..c9f295e7e449 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -908,6 +908,7 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p) p->status = USB_RET_STALL; break; } + return; err_stream: error_report("%s: invalid stream %d", __func__, p->stream);
Otherwise we run the error handling code even for successful requests. Fixes: 13b250b12ad3 ("uas: add stream number sanity checks.") Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/usb/dev-uas.c | 1 + 1 file changed, 1 insertion(+)