From patchwork Wed Dec 29 19:21:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 12701097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 605DFC433F5 for ; Wed, 29 Dec 2021 19:25:54 +0000 (UTC) Received: from localhost ([::1]:59042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2ea8-0000tF-Sj for qemu-devel@archiver.kernel.org; Wed, 29 Dec 2021 14:25:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2eWK-0006bC-AW; Wed, 29 Dec 2021 14:21:57 -0500 Received: from mail-eopbgr70107.outbound.protection.outlook.com ([40.107.7.107]:6337 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2eWF-0000B6-VW; Wed, 29 Dec 2021 14:21:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMnlTw95WcdaKPpVZ0U5nVmGauz76bh6R8C+RZ0iJGMIcb7j7YW+NJrnWr3ZUgzNWtFxDuEsECKG137M7GxqcDO2YpJq00mOmSxB/YVTlbyMlciUYMf1zFQZ8jCs3kFFataARjhophccYOd32uxBZSzCngg0HXP03i8DS3kD6LRSXzEVKKrNInpDx7g+LrBfCCk7ofLzlkNWIhreIzSkG2dh2c/xLpsnEF9oA9BLOQInCh+xvOJ0cPNdzU6GSCj7pu8/EfNPeOjvQyIOuemAtPHqjdV6WtDko/dGS2LqbXonsPKGvrBH8Qao50HXUu+JdLeAykCxV65x/KEyOzTp6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p4yPRjkH8qwCYrJOwOXKV9Jq+PT/sa0b2rVxOh+oEVM=; b=bQD2K7xnc2Uhz2oD1yfU31/hFCKqYVI+vV3W4hLqs4SAqLDEoYvWMxUeeI2NscEAu6PMZVQJ/JKm2KgLWsM85fsUY58/deXieem1dQnT86LAQhHdjXlPoMDeKdyVIzOGSj4oG/+Mkc1wCqP7mzjXSTPKs1xr9O7nEVoM9uGUnG+Ep75JT34bI2+yANVs5jhAL7b5+ynvpzA7EJUnmeHGMVOpzmEEb9Wq6UjpDf+xvkMDN/oNE0LCW+qlkkclrH3kWVJ6oFkTUBP3Atxpx2hvmjA3+oGMQOpdQ6LgkMuJFiVAKntZqE/z4Wr/4NJHLcRQ/IlYWxtmSzkFlAjM2AF6pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4yPRjkH8qwCYrJOwOXKV9Jq+PT/sa0b2rVxOh+oEVM=; b=oPOCmjRfml+9hRtdtdw6CshSUqAacXOUaxAm5Vx2Sqq6uWHgIF+RWB6+NT6cFoxC+mw6NHSpRzqDx7jqWje6zyeaqXO4OeueZ+RBfUEMoPGvlN+rxDVp8UnfDZqiWXFO28l8kCfSFojkojh5uhh40zFCttul8h/JlLDpmBQJBKQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM9PR08MB6737.eurprd08.prod.outlook.com (2603:10a6:20b:304::18) by AM4PR0802MB2276.eurprd08.prod.outlook.com (2603:10a6:200:5f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 29 Dec 2021 19:21:44 +0000 Received: from AM9PR08MB6737.eurprd08.prod.outlook.com ([fe80::b118:483a:d003:3112]) by AM9PR08MB6737.eurprd08.prod.outlook.com ([fe80::b118:483a:d003:3112%5]) with mapi id 15.20.4823.023; Wed, 29 Dec 2021 19:21:44 +0000 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, vsementsov@virtuozzo.com, jsnow@redhat.com, Emanuele Giuseppe Esposito , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Stefan Hajnoczi Subject: [PULL 1/6] job.c: add missing notifier initialization Date: Wed, 29 Dec 2021 20:21:22 +0100 Message-Id: <20211229192127.1772134-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211229192127.1772134-1-vsementsov@virtuozzo.com> References: <20211229192127.1772134-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AS8PR04CA0152.eurprd04.prod.outlook.com (2603:10a6:20b:331::7) To AM9PR08MB6737.eurprd08.prod.outlook.com (2603:10a6:20b:304::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0faad136-ce96-4ab7-1dc0-08d9cb0072ee X-MS-TrafficTypeDiagnostic: AM4PR0802MB2276:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:962; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WtrEPN0OJDn12iDL5hGBnXLH8b488m16Q6spWH9JOtEnsMwT1ASNMEreEG4dctXU+13OCCM940pN5Mj3I2tv+w1TnpFlYCFmyf0K94v/KaGs9bJqn1hatiuCl3eZiAiR/f2desC5hvPsk4Qy9cnzRqYC94gTcsFxr8rwzlWkpAYIaO7/e8bg9IQt5cF8+/AIRj7OQlXS7MHyS1BiWFIAklQgLMgVNwJjZrwkUjkx0WlP3afxfX5uLIeh4a7fsvn9HlOYv71JVTeP/Ukd6jiu84DOsgaG9rOkhHITOf0724LuYO1BPB0reDy+YzXwgURnI0wB0xKRXrieaTBRLbkPy2xuDCkxHQGhCT+J04cMHiEPWenLINbal4z/KADFamck2VcvgdNKP8qz8hyXmScTKNRuKJfZorkX5usB6huuMjZXQPfLfJIOMj64YvCGVd+YoYiPw5jLc5fMoldQyoyEaN57IoP9VDOPZKEs4Quc8W90r2HRWvPxemeSbpalwpADU+W2GS25OvGFkPkiY5iz70bPUl+m4XKCM0UdYKRSqREvbMEqjlXoDuyMFfnNS/vPG1yVDj4Y87+fbapKb+JVgx49kECrGytpc33LGTCTtHoNn8IsAJbIWR0zBuAINkgCeHq/genqW/tgM1UGnOuK2qdFycrHCFGikl5jHowK9NxFBIJ/6UXVxtnutEXD9O3wSGhOFwpIQtiQ4UBPOIU0Og== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR08MB6737.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(52116002)(1076003)(6666004)(83380400001)(2616005)(2906002)(6512007)(36756003)(7416002)(6506007)(316002)(86362001)(38350700002)(8676002)(54906003)(66556008)(66946007)(66476007)(6916009)(38100700002)(5660300002)(8936002)(6486002)(186003)(26005)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/7rxhJZQb4ER6/WR5uM9yK1ZcV4m?= =?utf-8?q?J0dutii4eDPCfGTW2KHilBr95aI4sB7RWMHsVCOZdKA3KUFrLAhR5ke+1l9AzxLcV?= =?utf-8?q?W7yllPvr9Y/n3BPxjCzyN7WYgOq2WniICsBxCO06bh8lDNfL15DL09tLSOoFSbcWa?= =?utf-8?q?8PKQolZvZliLKt6254+7WlR6Y2jlpb4KAJKfNpXNoZDAnXfdpIjMOCSAOMegTg/oI?= =?utf-8?q?zzvgUYxhst5W+qGG1cwRrPhxUXSCUBL9X6b+HjUbOrC7uMCGb6b0NCD07Ni0KaAdO?= =?utf-8?q?XNKiXlndCwllpGzTcjDesRWQ6GfQLlKVk673PldtdTcZ8GVneuGLjkX/+cfcbK4uY?= =?utf-8?q?9EX/5phjyp2U9WLNvF51yTKgChr5rxTVYHHs/cXSUjBVMB5hxIKIoRKATbWNwIYuH?= =?utf-8?q?0VuEBV7c6h+MWNj0ATufo7OYnD2fr7UPVndnOWDbshmPjeGN17Owbshwdm+KmrYkY?= =?utf-8?q?zhdP/BHgDK6FkpTrnfKI6d/UkuV3eJ3jkkBQY0P35MuquxXmC0iYmUvhc7K7lTWYL?= =?utf-8?q?TD1rGFguigbJJmjFVc0TdFaeFzJGelxDJ0KsnoStK8cFi/Oj5l3i91bM33gBKzbkQ?= =?utf-8?q?r2EIhRnRPK/QAAjuFixyfuhdx7HLdIFJqQYnU3I05FNkt4ROYeixccT3G7i3LnL1r?= =?utf-8?q?pqNfseBkiFrpamSwSnxj1GpvIW9dqBUzemJwlPSC0MKHXlfuZ7lEBjma+NzeySg/D?= =?utf-8?q?rDf2qzAbRI7f+/grc8h5Ih98w9jYnFqVotP/UuLM9uteo43K1JIhtpBGXNkMJXEB+?= =?utf-8?q?jGS64EelNQlfhopgDvJt4OwrO+BFi/RBZjfHwJfX2Udzck7rhAyA21Dv4FHhLpYOL?= =?utf-8?q?OfPU7u9jdfMfX4Cl525LFptyhrFijAZ+wGLQLfA/S5bw4YJhoc/ytS5X1xC+3vDDU?= =?utf-8?q?6gvheaD1BbsbAGhLpIbm9ENBu7yAz6YeYpwcg3Jxi+E/33htDqHRGPrCX7GPIGHl5?= =?utf-8?q?rL/jsA7ELYD3CUpea4yuDxFlqncPOCgnj40FkW81Vx/xge0b22QzJ9SbjHVYpUF8E?= =?utf-8?q?RoOGPnWoRXihLTNkcEDYYLGGtJ9gY2ppZJy1pnxsF6IOSdDpkx4maWEx85DWNCgoT?= =?utf-8?q?7IlIIfZ3OGu8SYr6d2E+OF9B3NQY/KbXX39WDx40AGDtwNOk0RXESoxCtGlp35OZT?= =?utf-8?q?QpsiHOh7s8A2rVivFml+VsU42szclGoKZ+vJ9pnDO9YkGulfxfk3WZTsk9eplcnLj?= =?utf-8?q?ifndzbCTnJy+wyi9RL9/sn9TZVHfNPOKBSMNpriW6+k9PQxtWhaLLyDCMrXRlu17s?= =?utf-8?q?1A/zQlAG7mHtyaULDBadccOK4OMaUV8aWrfyO5cf50SZAbo5vWRaGMfDeTTRpKc4v?= =?utf-8?q?hPU4IpBBS8DsvW4EnZS18lCbvAB6PYNep+0msGCsdPQD34IMcw7I0F4LbiXOEtTI4?= =?utf-8?q?lBJs5T6+DvkbO3kbxx5OPFxn1B1R7odKBrvKyOXH3uC1TutXu8YxAZ3x9KPW5Hste?= =?utf-8?q?l+LC6p3HzwBIB3TXIOrqDh5Buit5Anruf0WD/g5VwFyy02mq+N0YtoSlyr876SouK?= =?utf-8?q?HAwFwe1HP+GmUF/DPRRJn4FtbDcHi8ZBpD2Y+EErR28Jl7m+lc6ZjH4XmKiyvXa5m?= =?utf-8?q?Mrrb41VSEshf0IqaCFCPN+chMMqjQbPS4fLzM1WTLo1aSVFeqfXRak=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0faad136-ce96-4ab7-1dc0-08d9cb0072ee X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB6737.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 19:21:43.9688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+uJ74H+XyzUh0ifYFNFYcE+GnJYjvmu+7NSwEM08aU4a1qRCtPG2KSqqeZJ/AtSWL9qI5jVOQnCRxbPUfHlZP8hAk77eogcTgpxnnkAQy4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2276 Received-SPF: pass client-ip=40.107.7.107; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Emanuele Giuseppe Esposito It seems that on_idle list is not properly initialized like the other notifiers. Fixes: 34dc97b9a0e ("blockjob: Wake up BDS when job becomes idle") Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy --- job.c | 1 + 1 file changed, 1 insertion(+) diff --git a/job.c b/job.c index dbfa67bb0a..54db80df66 100644 --- a/job.c +++ b/job.c @@ -352,6 +352,7 @@ void *job_create(const char *job_id, const JobDriver *driver, JobTxn *txn, notifier_list_init(&job->on_finalize_completed); notifier_list_init(&job->on_pending); notifier_list_init(&job->on_ready); + notifier_list_init(&job->on_idle); job_state_transition(job, JOB_STATUS_CREATED); aio_timer_init(qemu_get_aio_context(), &job->sleep_timer,