diff mbox series

[1/2] build-sys: fix undefined ARCH error

Message ID 20220114084312.3725242-1-marcandre.lureau@redhat.com (mailing list archive)
State New, archived
Headers show
Series [1/2] build-sys: fix undefined ARCH error | expand

Commit Message

Marc-André Lureau Jan. 14, 2022, 8:43 a.m. UTC
From: Marc-André Lureau <marcandre.lureau@redhat.com>

../qga/meson.build:76:4: ERROR: Key ARCH is not in the dictionary.

Fixes commit 823eb013 ("configure, meson: move ARCH to meson.build")

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 qga/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Jan. 14, 2022, 11:11 a.m. UTC | #1
On 14/1/22 09:43, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../qga/meson.build:76:4: ERROR: Key ARCH is not in the dictionary.
> 
> Fixes commit 823eb013 ("configure, meson: move ARCH to meson.build")
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   qga/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Paolo Bonzini Jan. 15, 2022, 4:06 p.m. UTC | #2
On 1/14/22 09:43, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../qga/meson.build:76:4: ERROR: Key ARCH is not in the dictionary.
> 
> Fixes commit 823eb013 ("configure, meson: move ARCH to meson.build")
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   qga/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/meson.build b/qga/meson.build
> index cfb1fbc0853c..613ecb980286 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -75,7 +75,7 @@ if targetos == 'windows'
>       endif
>       qga_msi = custom_target('QGA MSI',
>                               input: files('installer/qemu-ga.wxs'),
> -                            output: 'qemu-ga-@0@.msi'.format(config_host['ARCH']),
> +                            output: 'qemu-ga-@0@.msi'.format(host_arch),
>                               depends: deps,
>                               command: [
>                                 find_program('env'),

Queued both, thanks.

Paolo
diff mbox series

Patch

diff --git a/qga/meson.build b/qga/meson.build
index cfb1fbc0853c..613ecb980286 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -75,7 +75,7 @@  if targetos == 'windows'
     endif
     qga_msi = custom_target('QGA MSI',
                             input: files('installer/qemu-ga.wxs'),
-                            output: 'qemu-ga-@0@.msi'.format(config_host['ARCH']),
+                            output: 'qemu-ga-@0@.msi'.format(host_arch),
                             depends: deps,
                             command: [
                               find_program('env'),