| Message ID | 20220119193916.4138217-3-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Python: minor fixes | expand |
On Wed, Jan 19, 2022 at 02:39:13PM -0500, John Snow wrote: > The old legacy runner no longer seems to work with output logging, so we > can't see failure logs when a test case fails. The new runner doesn't > (seem to) support Coverage.py yet, but seeing error output is a more > important feature. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > python/avocado.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/python/avocado.cfg b/python/avocado.cfg > index c7722e7ecd..a460420059 100644 > --- a/python/avocado.cfg > +++ b/python/avocado.cfg > @@ -1,5 +1,5 @@ > [run] > -test_runner = runner > +test_runner = nrunner > > [simpletests] > # Don't show stdout/stderr in the test *summary* Since Avocado 82, the new one is the default. So, you could remove the the "[run]" section. In any case: Reviewed-by: Beraldo Leal <bleal@redhat.com> -- Beraldo
On Thu, Jan 20, 2022 at 8:08 AM Beraldo Leal <bleal@redhat.com> wrote: > > On Wed, Jan 19, 2022 at 02:39:13PM -0500, John Snow wrote: > > The old legacy runner no longer seems to work with output logging, so we > > can't see failure logs when a test case fails. The new runner doesn't > > (seem to) support Coverage.py yet, but seeing error output is a more > > important feature. > > > > Signed-off-by: John Snow <jsnow@redhat.com> > > --- > > python/avocado.cfg | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/python/avocado.cfg b/python/avocado.cfg > > index c7722e7ecd..a460420059 100644 > > --- a/python/avocado.cfg > > +++ b/python/avocado.cfg > > @@ -1,5 +1,5 @@ > > [run] > > -test_runner = runner > > +test_runner = nrunner > > > > [simpletests] > > # Don't show stdout/stderr in the test *summary* > > Since Avocado 82, the new one is the default. So, you could remove the > the "[run]" section. > I think it was actually since 91.0, but I figured it was more obvious to reviewers to see the explicit change. Less to explain, and it will explode a little more if you use an avocado old enough that doesn't have the nrunner. > In any case: > > Reviewed-by: Beraldo Leal <bleal@redhat.com> > Thanks, --js
diff --git a/python/avocado.cfg b/python/avocado.cfg index c7722e7ecd..a460420059 100644 --- a/python/avocado.cfg +++ b/python/avocado.cfg @@ -1,5 +1,5 @@ [run] -test_runner = runner +test_runner = nrunner [simpletests] # Don't show stdout/stderr in the test *summary*
The old legacy runner no longer seems to work with output logging, so we can't see failure logs when a test case fails. The new runner doesn't (seem to) support Coverage.py yet, but seeing error output is a more important feature. Signed-off-by: John Snow <jsnow@redhat.com> --- python/avocado.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)