| Message ID | 20220121202733.404989-4-eperezma@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vDPA shadow virtqueue | expand |
在 2022/1/22 上午4:27, Eugenio Pérez 写道: > Is needed so vhost-vdpa knows the device's kick event fd. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > --- > hw/virtio/vhost-shadow-virtqueue.h | 4 ++++ > hw/virtio/vhost-shadow-virtqueue.c | 10 +++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-virtqueue.h > index 61ea112002..400effd9f2 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.h > +++ b/hw/virtio/vhost-shadow-virtqueue.h > @@ -11,9 +11,13 @@ > #define VHOST_SHADOW_VIRTQUEUE_H > > #include "hw/virtio/vhost.h" > +#include "qemu/event_notifier.h" Let's move this part to patch 2. Thanks > > typedef struct VhostShadowVirtqueue VhostShadowVirtqueue; > > +const EventNotifier *vhost_svq_get_dev_kick_notifier( > + const VhostShadowVirtqueue *svq); > + > VhostShadowVirtqueue *vhost_svq_new(void); > > void vhost_svq_free(VhostShadowVirtqueue *vq); > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c > index 5ee7b401cb..bd87110073 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.c > +++ b/hw/virtio/vhost-shadow-virtqueue.c > @@ -11,7 +11,6 @@ > #include "hw/virtio/vhost-shadow-virtqueue.h" > > #include "qemu/error-report.h" > -#include "qemu/event_notifier.h" > > /* Shadow virtqueue to relay notifications */ > typedef struct VhostShadowVirtqueue { > @@ -21,6 +20,15 @@ typedef struct VhostShadowVirtqueue { > EventNotifier hdev_call; > } VhostShadowVirtqueue; > > +/** > + * The notifier that SVQ will use to notify the device. > + */ > +const EventNotifier *vhost_svq_get_dev_kick_notifier( > + const VhostShadowVirtqueue *svq) > +{ > + return &svq->hdev_kick; > +} > + > /** > * Creates vhost shadow virtqueue, and instruct vhost device to use the shadow > * methods and file descriptors.
On Fri, Jan 28, 2022 at 7:03 AM Jason Wang <jasowang@redhat.com> wrote: > > > 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > > Is needed so vhost-vdpa knows the device's kick event fd. > > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > > --- > > hw/virtio/vhost-shadow-virtqueue.h | 4 ++++ > > hw/virtio/vhost-shadow-virtqueue.c | 10 +++++++++- > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-virtqueue.h > > index 61ea112002..400effd9f2 100644 > > --- a/hw/virtio/vhost-shadow-virtqueue.h > > +++ b/hw/virtio/vhost-shadow-virtqueue.h > > @@ -11,9 +11,13 @@ > > #define VHOST_SHADOW_VIRTQUEUE_H > > > > #include "hw/virtio/vhost.h" > > +#include "qemu/event_notifier.h" > > > Let's move this part to patch 2. > Sure, I'll change for the next revision. > Thanks > > > > > > typedef struct VhostShadowVirtqueue VhostShadowVirtqueue; > > > > +const EventNotifier *vhost_svq_get_dev_kick_notifier( > > + const VhostShadowVirtqueue *svq); > > + > > VhostShadowVirtqueue *vhost_svq_new(void); > > > > void vhost_svq_free(VhostShadowVirtqueue *vq); > > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c > > index 5ee7b401cb..bd87110073 100644 > > --- a/hw/virtio/vhost-shadow-virtqueue.c > > +++ b/hw/virtio/vhost-shadow-virtqueue.c > > @@ -11,7 +11,6 @@ > > #include "hw/virtio/vhost-shadow-virtqueue.h" > > > > #include "qemu/error-report.h" > > -#include "qemu/event_notifier.h" > > > > /* Shadow virtqueue to relay notifications */ > > typedef struct VhostShadowVirtqueue { > > @@ -21,6 +20,15 @@ typedef struct VhostShadowVirtqueue { > > EventNotifier hdev_call; > > } VhostShadowVirtqueue; > > > > +/** > > + * The notifier that SVQ will use to notify the device. > > + */ > > +const EventNotifier *vhost_svq_get_dev_kick_notifier( > > + const VhostShadowVirtqueue *svq) > > +{ > > + return &svq->hdev_kick; > > +} > > + > > /** > > * Creates vhost shadow virtqueue, and instruct vhost device to use the shadow > > * methods and file descriptors. >
diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-virtqueue.h index 61ea112002..400effd9f2 100644 --- a/hw/virtio/vhost-shadow-virtqueue.h +++ b/hw/virtio/vhost-shadow-virtqueue.h @@ -11,9 +11,13 @@ #define VHOST_SHADOW_VIRTQUEUE_H #include "hw/virtio/vhost.h" +#include "qemu/event_notifier.h" typedef struct VhostShadowVirtqueue VhostShadowVirtqueue; +const EventNotifier *vhost_svq_get_dev_kick_notifier( + const VhostShadowVirtqueue *svq); + VhostShadowVirtqueue *vhost_svq_new(void); void vhost_svq_free(VhostShadowVirtqueue *vq); diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c index 5ee7b401cb..bd87110073 100644 --- a/hw/virtio/vhost-shadow-virtqueue.c +++ b/hw/virtio/vhost-shadow-virtqueue.c @@ -11,7 +11,6 @@ #include "hw/virtio/vhost-shadow-virtqueue.h" #include "qemu/error-report.h" -#include "qemu/event_notifier.h" /* Shadow virtqueue to relay notifications */ typedef struct VhostShadowVirtqueue { @@ -21,6 +20,15 @@ typedef struct VhostShadowVirtqueue { EventNotifier hdev_call; } VhostShadowVirtqueue; +/** + * The notifier that SVQ will use to notify the device. + */ +const EventNotifier *vhost_svq_get_dev_kick_notifier( + const VhostShadowVirtqueue *svq) +{ + return &svq->hdev_kick; +} + /** * Creates vhost shadow virtqueue, and instruct vhost device to use the shadow * methods and file descriptors.
Is needed so vhost-vdpa knows the device's kick event fd. Signed-off-by: Eugenio Pérez <eperezma@redhat.com> --- hw/virtio/vhost-shadow-virtqueue.h | 4 ++++ hw/virtio/vhost-shadow-virtqueue.c | 10 +++++++++- 2 files changed, 13 insertions(+), 1 deletion(-)