Message ID | 20220202143422.912070-1-lvivier@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | qemu-options: fix incorrect description for '-drive index=' | expand |
On 02/02/2022 15.34, Laurent Vivier wrote: > qemu-options.hx contains grammar that a native English-speaking > person would never use. > > Replace "This option defines where is connected the drive" by > "This option defines where the drive is connected". > > Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853 I'd prefer: Fixes: e0e7ada1d5 ("Update documention with '-drive' usage") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/853 but anyway: Reviewed-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index ba3ae6a42aa3..094a6c1d7c28 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1377,7 +1377,7 @@ SRST > the bus number and the unit id. > > ``index=index`` > - This option defines where is connected the drive by using an > + This option defines where the drive is connected by using an > index in the list of available connectors of a given interface > type. >
Le 02/02/2022 à 15:34, Laurent Vivier a écrit : > qemu-options.hx contains grammar that a native English-speaking > person would never use. > > Replace "This option defines where is connected the drive" by > "This option defines where the drive is connected". > > Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853 > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index ba3ae6a42aa3..094a6c1d7c28 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1377,7 +1377,7 @@ SRST > the bus number and the unit id. > > ``index=index`` > - This option defines where is connected the drive by using an > + This option defines where the drive is connected by using an > index in the list of available connectors of a given interface > type. > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/qemu-options.hx b/qemu-options.hx index ba3ae6a42aa3..094a6c1d7c28 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1377,7 +1377,7 @@ SRST the bus number and the unit id. ``index=index`` - This option defines where is connected the drive by using an + This option defines where the drive is connected by using an index in the list of available connectors of a given interface type.
qemu-options.hx contains grammar that a native English-speaking person would never use. Replace "This option defines where is connected the drive" by "This option defines where the drive is connected". Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853 Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)