| Message ID | 20220226115953.60335-1-akihiko.odaki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] coreaudio: Notify error in coreaudio_init_out | expand |
On 26/2/22 12:59, Akihiko Odaki wrote: > Otherwise, the audio subsystem tries to use the voice and > eventually aborts due to the maximum number of samples in the > buffer is not set. > > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> > Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com> > --- > audio/coreaudio.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 26/2/22 12:59, Akihiko Odaki wrote: > Otherwise, the audio subsystem tries to use the voice and > eventually aborts due to the maximum number of samples in the > buffer is not set. > > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> > Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com> > --- > audio/coreaudio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/audio/coreaudio.c b/audio/coreaudio.c > index d8a21d3e507..d7cfdcc4fc4 100644 > --- a/audio/coreaudio.c > +++ b/audio/coreaudio.c > @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, > coreaudio_playback_logerr(status, > "Could not remove voice property change listener\n"); > } > + > + return -1; > } > > return 0; Merged as commit bd7819de22.
diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d8a21d3e507..d7cfdcc4fc4 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, coreaudio_playback_logerr(status, "Could not remove voice property change listener\n"); } + + return -1; } return 0;