| Message ID | 20220309083858.58117-4-chen.zhang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | COLO net and runstate bugfix/optimization | expand |
On 09/03/2022 16:38, Zhang Chen wrote: > Filter-rewriter no need to track connection in conn_list. > This patch fix the glib g_queue_is_empty assertion when COLO guest > keep a lot of network connection. > > Signed-off-by: Zhang Chen <chen.zhang@intel.com> LGTM. Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> > --- > net/colo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/colo.c b/net/colo.c > index 1f8162f59f..694f3c93ef 100644 > --- a/net/colo.c > +++ b/net/colo.c > @@ -218,7 +218,7 @@ Connection *connection_get(GHashTable *connection_track_table, > /* > * clear the conn_list > */ > - while (!g_queue_is_empty(conn_list)) { > + while (conn_list && !g_queue_is_empty(conn_list)) { > connection_destroy(g_queue_pop_head(conn_list)); > } > }
diff --git a/net/colo.c b/net/colo.c index 1f8162f59f..694f3c93ef 100644 --- a/net/colo.c +++ b/net/colo.c @@ -218,7 +218,7 @@ Connection *connection_get(GHashTable *connection_track_table, /* * clear the conn_list */ - while (!g_queue_is_empty(conn_list)) { + while (conn_list && !g_queue_is_empty(conn_list)) { connection_destroy(g_queue_pop_head(conn_list)); } }
Filter-rewriter no need to track connection in conn_list. This patch fix the glib g_queue_is_empty assertion when COLO guest keep a lot of network connection. Signed-off-by: Zhang Chen <chen.zhang@intel.com> --- net/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)