| Message ID | 20220324183018.2476551-16-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iotests: add enhanced debugging info to qemu-io failures | expand |
On Thu, Mar 24, 2022 at 02:30:16PM -0400, John Snow wrote: > I know we just added it, sorry. This is done in favor of qemu_io() which > *also* returns the console output and status, but with more robust error > handling on failure. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > tests/qemu-iotests/iotests.py | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On 24.03.22 19:30, John Snow wrote: > I know we just added it, sorry. This is done in favor of qemu_io() which > *also* returns the console output and status, but with more robust error > handling on failure. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > tests/qemu-iotests/iotests.py | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Hanna Reitz <hreitz@redhat.com>
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index baf4995089..e903c8ede0 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -365,9 +365,6 @@ def qemu_io(*args: str, check: bool = True, combine_stdio: bool = True return qemu_tool(*qemu_io_wrap_args(args), check=check, combine_stdio=combine_stdio) -def qemu_io_pipe_and_status(*args): - return qemu_tool_pipe_and_status('qemu-io', qemu_io_wrap_args(args)) - def qemu_io_log(*args: str) -> 'subprocess.CompletedProcess[str]': result = qemu_io(*args, check=False) log(result.stdout, filters=[filter_testfiles, filter_qemu_io])
I know we just added it, sorry. This is done in favor of qemu_io() which *also* returns the console output and status, but with more robust error handling on failure. Signed-off-by: John Snow <jsnow@redhat.com> --- tests/qemu-iotests/iotests.py | 3 --- 1 file changed, 3 deletions(-)