| Message ID | 20220401190631.1697408-2-tong.ho@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 | expand |
On [2022 Apr 01] Fri 12:06:31, Tong Ho wrote: > This adds required initialization of Error * variable. > > Signed-off-by: Tong Ho <tong.ho@xilinx.com> Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com> > --- > hw/nvram/xlnx-bbram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c > index b70828e5bf..6ed32adad9 100644 > --- a/hw/nvram/xlnx-bbram.c > +++ b/hw/nvram/xlnx-bbram.c > @@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s) > > static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *detail) > { > - Error *errp; > + Error *errp = NULL; > > error_setg_errno(&errp, -rc, "%s: BBRAM backstore %s failed.", > blk_name(s->blk), detail); > -- > 2.25.1 > >
diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c index b70828e5bf..6ed32adad9 100644 --- a/hw/nvram/xlnx-bbram.c +++ b/hw/nvram/xlnx-bbram.c @@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s) static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *detail) { - Error *errp; + Error *errp = NULL; error_setg_errno(&errp, -rc, "%s: BBRAM backstore %s failed.", blk_name(s->blk), detail);
This adds required initialization of Error * variable. Signed-off-by: Tong Ho <tong.ho@xilinx.com> --- hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)