| Message ID | 20220407083932.531965-1-den@openvz.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] qemu-img: properly list formats which have consistency check implemented | expand |
On Thu, Apr 07, 2022 at 11:39:32AM +0300, Denis V. Lunev wrote: > Simple grep for the .bdrv_co_check callback presence gives the following > list of block drivers > * QED > * VDI > * VHDX > * VMDK > * Parallels > which have this callback. The presense of the callback means that > consistency check is supported. > > The patch updates documentation accordingly. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Kevin Wolf <kwolf@redhat.com> > CC: Hanna Reitz <hreitz@redhat.com> > --- > docs/tools/qemu-img.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
Am 07.04.2022 um 10:39 hat Denis V. Lunev geschrieben: > Simple grep for the .bdrv_co_check callback presence gives the following > list of block drivers > * QED > * VDI > * VHDX > * VMDK > * Parallels > which have this callback. The presense of the callback means that > consistency check is supported. > > The patch updates documentation accordingly. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > CC: Kevin Wolf <kwolf@redhat.com> > CC: Hanna Reitz <hreitz@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 8885ea11cf..85a6e05b35 100644 --- a/docs/tools/qemu-img.rst +++ b/docs/tools/qemu-img.rst @@ -332,8 +332,8 @@ by the used format or see the format descriptions below for details. ``-r all`` fixes all kinds of errors, with a higher risk of choosing the wrong fix or hiding corruption that has already occurred. - Only the formats ``qcow2``, ``qed`` and ``vdi`` support - consistency checks. + Only the formats ``qcow2``, ``qed``, ``parallels``, ``vhdx``, ``vmdk`` and + ``vdi`` support consistency checks. In case the image does not have any inconsistencies, check exits with ``0``. Other exit codes indicate the kind of inconsistency found or if another error
Simple grep for the .bdrv_co_check callback presence gives the following list of block drivers * QED * VDI * VHDX * VMDK * Parallels which have this callback. The presense of the callback means that consistency check is supported. The patch updates documentation accordingly. Signed-off-by: Denis V. Lunev <den@openvz.org> CC: Kevin Wolf <kwolf@redhat.com> CC: Hanna Reitz <hreitz@redhat.com> --- docs/tools/qemu-img.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)