diff mbox series

[31/50] ps2: make ps2_raise_irq() function static

Message ID	20220522181836.864-32-mark.cave-ayland@ilande.co.uk (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> To: richard.henderson@linaro.org, deller@gmx.de, mst@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, hpoussin@reactos.org, aleksandar.rikalo@syrmia.com, f4bug@amsat.org, jiaxun.yang@flygoat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Sun, 22 May 2022 19:18:17 +0100 Message-Id: <20220522181836.864-32-mark.cave-ayland@ilande.co.uk> In-Reply-To: <20220522181836.864-1-mark.cave-ayland@ilande.co.uk> References: <20220522181836.864-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [PATCH 31/50] ps2: make ps2_raise_irq() function static Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>
Series	PS2 device QOMification - part 1 \| expand [00/50] PS2 device QOMification - part 1 [01/50] ps2: checkpatch fixes [02/50] ps2: QOMify PS2State [03/50] ps2: QOMify PS2KbdState [04/50] ps2: QOMify PS2MouseState [05/50] ps2: move QOM type definitions from ps2.c to ps2.h [06/50] ps2: improve function prototypes in ps2.c and ps2.h [07/50] ps2: introduce PS2DeviceClass [08/50] ps2: implement ps2_reset() for the PS2_DEVICE QOM type based upon ps2_common_reset() [09/50] ps2: remove duplicate setting of scancode_set in ps2_kbd_init() [10/50] ps2: implement ps2_kbd_realize() and use it to register ps2_keyboard_handler [11/50] ps2: implement ps2_mouse_realize() and use it to register ps2_mouse_handler [12/50] ps2: don't use vmstate_register() in ps2_kbd_init() [13/50] ps2: don't use vmstate_register() in ps2_mouse_init() [14/50] pl050: checkpatch fixes [15/50] pl050: split pl050_update_irq() into separate pl050_set_irq() and pl050_update_irq() functi… [16/50] lasips2: spacing fixes [17/50] lasips2: rename ps2dev_update_irq() to lasips2_port_set_irq() [18/50] pckbd: checkpatch fixes [19/50] pckbd: move KBDState from pckbd.c to i8042.h [20/50] pckbd: move ISAKBDState from pckbd.c to i8042.h [21/50] pckbd: introduce new I8042_MMIO QOM type [22/50] pckbd: implement i8042_mmio_reset() for I8042_MMIO device [23/50] pckbd: add mask qdev property to I8042_MMIO device [24/50] pckbd: add size qdev property to I8042_MMIO device [25/50] pckbd: implement i8042_mmio_realize() function [26/50] pckbd: implement i8042_mmio_init() function [27/50] pckbd: alter i8042_mm_init() to return a I8042_MMIO device [28/50] pckbd: move mapping of I8042_MMIO registers to MIPS magnum machine [29/50] pckbd: more vmstate_register() from i8042_mm_init() to i8042_mmio_realize() [30/50] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize() [31/50] ps2: make ps2_raise_irq() function static [32/50] ps2: use ps2_raise_irq() instead of calling update_irq() directly [33/50] ps2: introduce ps2_lower_irq() instead of calling update_irq() directly [34/50] ps2: add gpio for output IRQ and optionally use it in ps2_raise_irq() and ps2_lower_irq() [35/50] pckbd: replace irq_kbd and irq_mouse with qemu_irq array in KBDState [36/50] pl050: switch over from update_irq() function to PS2 device gpio [37/50] lasips2: QOMify LASIPS2State [38/50] lasips2: move lasips2 QOM types from lasips2.c to lasips2.h [39/50] lasips2: rename lasips2_init() to lasips2_initfn() and update it to return the LASIPS2 devi… [40/50] lasips2: implement lasips2_init() function [41/50] lasips2: move mapping of LASIPS2 registers to HPPA machine [42/50] lasips2: move initialisation of PS2 ports from lasi_initfn() to lasi_init() [43/50] lasips2: add base property [44/50] lasips2: implement lasips2_realize() [45/50] lasips2: use qdev gpio for output IRQ [46/50] lasips2: switch over from update_irq() function to PS2 device gpio [47/50] pckbd: switch I8042_MMIO device from update_irq() function to PS2 device gpio [48/50] pckbd: add i8042_reset() function to I8042 device [49/50] pckbd: switch I8042 device from update_irq() function to PS2 device gpio [50/50] ps2: remove update_irq() function and update_arg parameter

Commit Message

Mark Cave-Ayland May 22, 2022, 6:18 p.m. UTC

This function is no longer used outside of ps2.c and so can be declared static.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/input/ps2.c         | 2 +-
 include/hw/input/ps2.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Peter Maydell June 9, 2022, 11:01 a.m. UTC | #1

On Sun, 22 May 2022 at 19:20, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> This function is no longer used outside of ps2.c and so can be declared static.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

diff mbox series

Patch

diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index e3ee69870b..8b76ce1cdc 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -172,7 +172,7 @@  void ps2_queue_noirq(PS2State *s, int b)
     q->count++;
 }
 
-void ps2_raise_irq(PS2State *s)
+static void ps2_raise_irq(PS2State *s)
 {
     s->update_irq(s->update_arg, 1);
 }
diff --git a/include/hw/input/ps2.h b/include/hw/input/ps2.h
index 4e8de912c6..d04d291287 100644
--- a/include/hw/input/ps2.h
+++ b/include/hw/input/ps2.h
@@ -102,7 +102,6 @@  void ps2_write_mouse(PS2MouseState *s, int val);
 void ps2_write_keyboard(PS2KbdState *s, int val);
 uint32_t ps2_read_data(PS2State *s);
 void ps2_queue_noirq(PS2State *s, int b);
-void ps2_raise_irq(PS2State *s);
 void ps2_queue(PS2State *s, int b);
 void ps2_queue_2(PS2State *s, int b1, int b2);
 void ps2_queue_3(PS2State *s, int b1, int b2, int b3);