From patchwork Thu Sep 1 16:25:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 12962931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3635AECAAD1 for ; Thu, 1 Sep 2022 16:52:05 +0000 (UTC) Received: from localhost ([::1]:46888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTnQ9-0001Fz-SA for qemu-devel@archiver.kernel.org; Thu, 01 Sep 2022 12:52:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTn1z-0001uu-Ac for qemu-devel@nongnu.org; Thu, 01 Sep 2022 12:27:07 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:37531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTn1x-0001VT-J2 for qemu-devel@nongnu.org; Thu, 01 Sep 2022 12:27:02 -0400 Received: by mail-ed1-x52d.google.com with SMTP id b16so23297092edd.4 for ; Thu, 01 Sep 2022 09:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Lk5BY/vi+uufGxfeaoPsPFkaEoogAtEkcyasHy2Pd/s=; b=T/VT8ej2MA+bhgjSNhcAaLTUCsOeH4BnvgFqhXJRk+38MWqFya/yFnToyKgca8MX2T lIdFBGu4i4v05f8AhfZhLW/qrvcY+K116o8C+OheOcvV3yZlkk0mO2lBBzc6OKB/EU+E BSCGtWt1C5UDdab14C7KirnMxCTE3jb7hGMOdsso81Y5t5mUd45cvxcn8MFboHWCHEPP 3JR0AIVflOC21PSzpiFJSgLP4nHuVQpfn5rkZZGRqaX6K/RhV1AJFRXSR8enbCNGPTVY GgmfSB4fHjWsCEQLXzz3mOzXWl+HGF2JflOIE+NJHyEJsssr1um0u355yvHxsToEx6aO N11g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Lk5BY/vi+uufGxfeaoPsPFkaEoogAtEkcyasHy2Pd/s=; b=qVw3o1ZsnC4nEEgWB2sLT4uywx7uhFsuBx1y365SLByrUXEJN00mgxQU3UYybBxHP5 6yPZoy4SkAgvK74zujA7nzH/0MJWQ8zHVKH8/ybK8GL2jRBwgf5a8xoDUW1Yvf2lCTuP W1szPqG1IwRfVnPcUujZfd4bXLbLyo2TryG3dYJBIZpFu27bFXoMT1ZzU8Dq7OfG9bHX cPrZe2EwqbyIIi97WuTF96vJTfigvncAUxkqdWXA5YOh7t3XIGJl5xPtxWYq0rPNwqwr XbLzhbERhLD+C3qmpeiWW/aVA/cBEvU8WMaFEc9CY8y4LrPcW+7HLuXPUqplPoKxcRUs A+/A== X-Gm-Message-State: ACgBeo0cmyPvRgBGX9KdvFRRqmCsf4zGVKBfTYVflHtlmPaHylBODZqs l9GjD9KTrssQ0MN6LTpiXLDHmtCah20= X-Google-Smtp-Source: AA6agR5VBymWPOCnwVkwqPO/hgGuMq6/MiGuvLjXFnnv751pHnCDEd2cZa7ABCkEqE0SYO/h4UU0ag== X-Received: by 2002:a05:6402:5cd:b0:446:5965:f4af with SMTP id n13-20020a05640205cd00b004465965f4afmr29444178edx.12.1662049620117; Thu, 01 Sep 2022 09:27:00 -0700 (PDT) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id p6-20020aa7d306000000b00447c0dcbb99sm1587672edq.83.2022.09.01.09.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 09:26:59 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Her?= =?utf-8?q?v=C3=A9_Poussineau?= , Aurelien Jarno , Paolo Bonzini , Eduardo Habkost , Richard Henderson , Jiaxun Yang , Ani Sinha , Igor Mammedov , Marcel Apfelbaum , "Michael S. Tsirkin" , Bernhard Beschow Subject: [PATCH 13/42] hw/isa/piix3: Add size constraints to rcr_ops Date: Thu, 1 Sep 2022 18:25:44 +0200 Message-Id: <20220901162613.6939-14-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220901162613.6939-1-shentey@gmail.com> References: <20220901162613.6939-1-shentey@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=shentey@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" According to the PIIX3 datasheet, the reset control register is one byte in size. Moreover, PIIX4 has it, so add it to PIIX3 as well. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/piix3.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index b54ff1c948..c8c2dd6048 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -290,7 +290,11 @@ static uint64_t rcr_read(void *opaque, hwaddr addr, unsigned len) static const MemoryRegionOps rcr_ops = { .read = rcr_read, .write = rcr_write, - .endianness = DEVICE_LITTLE_ENDIAN + .endianness = DEVICE_LITTLE_ENDIAN, + .impl = { + .min_access_size = 1, + .max_access_size = 1, + }, }; static void pci_piix3_realize(PCIDevice *dev, Error **errp)