| Message ID | 20220905095522.66941-20-milica.lazarevic@syrmia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert nanoMIPS disassembler from C++ to C | expand |
On 9/5/22 10:55, Milica Lazarevic wrote: > Changed the type of the table parameter in Disassemble function: > - from const Pool * > - to const struct Pool * > > Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > --- > disas/nanomips.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp > index ab54456c2e..7315484464 100644 > --- a/disas/nanomips.cpp > +++ b/disas/nanomips.cpp > @@ -635,7 +635,7 @@ static uint64 extract_op_code_value(const uint16 *data, int size) > * disassembly string - on error will constain error string > */ > static int Disassemble(const uint16 *data, char *dis, > - TABLE_ENTRY_TYPE *type, const Pool *table, > + TABLE_ENTRY_TYPE *type, const struct Pool *table, > int table_size, struct Dis_info *info) > { > for (int i = 0; i < table_size; i++) { No, this means you're missing a typedef to comply with coding style. r~
diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp index ab54456c2e..7315484464 100644 --- a/disas/nanomips.cpp +++ b/disas/nanomips.cpp @@ -635,7 +635,7 @@ static uint64 extract_op_code_value(const uint16 *data, int size) * disassembly string - on error will constain error string */ static int Disassemble(const uint16 *data, char *dis, - TABLE_ENTRY_TYPE *type, const Pool *table, + TABLE_ENTRY_TYPE *type, const struct Pool *table, int table_size, struct Dis_info *info) { for (int i = 0; i < table_size; i++) {