From patchwork Tue Sep 20 10:31:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 12982150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42638ECAAD8 for ; Tue, 20 Sep 2022 13:11:34 +0000 (UTC) Received: from localhost ([::1]:44114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oad2D-0005zU-2g for qemu-devel@archiver.kernel.org; Tue, 20 Sep 2022 09:11:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaaZ2-0001HF-EM for qemu-devel@nongnu.org; Tue, 20 Sep 2022 06:33:17 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:41820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaaZ0-0004xP-Kb for qemu-devel@nongnu.org; Tue, 20 Sep 2022 06:33:15 -0400 Received: by mail-pl1-x635.google.com with SMTP id p18so1908593plr.8 for ; Tue, 20 Sep 2022 03:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=NRgpn8UKlLeZRK3O++E8fem4Ty/tJxVKgPqLLc5aG4c=; b=glAD/IZhxEcFnpja1UtXQZLuIViM9IvgwUNhPHqgzVWzJXSJ/13PGhSfLa+73QjYpn xdBFbyZXifD8VUhY2ZoNqh1Y5/HZzH8ulQQ51ezg3FWjn6ym0sK4DIT7WDaBXTUcD52u o5qw+ob+0wKzTDWEeqoAUEOseJkwHRxCej2rPaRJjLYKogvdS+dAMfFJQuz5eHanc8FE RdI0kgQXt9ha56+2eEgPCjUovXyD5mU0BH2l3rMBsRpCyS79xXpP4mA3xrVloHCPgDEo 1j8GBmksVHBGrg7KWpyDblO6y31QL5e/WoNlYCmeKIM3N5vt+RVGSiu0UjP0riGhLz+Z t/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=NRgpn8UKlLeZRK3O++E8fem4Ty/tJxVKgPqLLc5aG4c=; b=JkC//52HkRjcYIGqfms9eUpbKouzjrQSb5BTZMPldg83eREdRH2z8+73xfKbq84JxQ Amc0+1o+aTyGOD257rOdFWdhfhIEzYVV9k3C0lm5R2xKV7OaVeqUUodXKC3jUYsKFW32 q3ouRFnxQoqOgHpMxA056ioabtHh1PF18gFoQRFn4aCU+XFRXq0VJz4XO5WpgzOEwSPq CmWRSReK/WtolAgeQLXvKhyIEx40ISsUdBpaxyFbUgnjZQeyPbSgtkOykuh5/gLW9kH3 c5XTOEvKyzGuwp0/1uHenELg2ECBWZVCnGaexAiaf1ggAuTItx8q7xWtTNyhSAmFRvI6 odjA== X-Gm-Message-State: ACrzQf3iR0qc4dZx0o2YidcXyk/bz2FouBINNVKZz0a5nHdtRZWdx2OU a2MeJWShh/TFnRoN91+vdGnXZ01iGZA= X-Google-Smtp-Source: AMsMyM69UDXr/woFpJVFapBPB7NQ70ZJMwYOzBUPqvn728D4q++c0jvUj3aRZeoliKnsVYBh2Aj3gQ== X-Received: by 2002:a17:90b:14d2:b0:202:dd9c:4e98 with SMTP id jz18-20020a17090b14d200b00202dd9c4e98mr3148067pjb.62.1663669993180; Tue, 20 Sep 2022 03:33:13 -0700 (PDT) Received: from ubuntu.. (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id n2-20020aa79842000000b00551fa0e2b2dsm699573pfq.206.2022.09.20.03.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 03:33:12 -0700 (PDT) From: Bin Meng To: qemu-devel@nongnu.org Cc: Bin Meng , "Dr. David Alan Gilbert" , Juan Quintela , Laurent Vivier , Paolo Bonzini , Thomas Huth Subject: [PATCH v2 22/39] tests/qtest: migration-test: Disable IO redirection for win32 Date: Tue, 20 Sep 2022 18:31:42 +0800 Message-Id: <20220920103159.1865256-23-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220920103159.1865256-1-bmeng.cn@gmail.com> References: <20220920103159.1865256-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=bmeng.cn@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Bin Meng On Windows the QEMU executable is created via CreateProcess() and IO redirection does not work, so don't bother adding IO redirection to the command line. Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau --- Changes in v2: - Change the place that sets IO redirection in the command line tests/qtest/migration-test.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 9925691ead..c87afad9e8 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -648,7 +648,16 @@ static int test_migrate_start(QTestState **from, QTestState **to, } if (!getenv("QTEST_LOG") && args->hide_stderr) { +#ifndef _WIN32 ignore_stderr = "2>/dev/null"; +#else + /* + * On Windows the QEMU executable is created via CreateProcess() and + * IO redirection does not work, so don't bother adding IO redirection + * to the command line. + */ + ignore_stderr = ""; +#endif } else { ignore_stderr = ""; }