diff mbox series

[13/26] parallels: add missing coroutine_fn annotations

Message ID 20220922084924.201610-14-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show
Series block: fix coroutine_fn annotations | expand

Commit Message

Paolo Bonzini Sept. 22, 2022, 8:49 a.m. UTC
Callers of coroutine_fn must be coroutine_fn themselves, or the call
must be within "if (qemu_in_coroutine())".  Apply coroutine_fn to
functions where this holds.

Reviewed-by: Alberto Faria <afaria@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/parallels.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Kevin Wolf Oct. 5, 2022, 10:44 a.m. UTC | #1
Am 22.09.2022 um 10:49 hat Paolo Bonzini geschrieben:
> Callers of coroutine_fn must be coroutine_fn themselves, or the call
> must be within "if (qemu_in_coroutine())".  Apply coroutine_fn to
> functions where this holds.
> 
> Reviewed-by: Alberto Faria <afaria@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/parallels.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/block/parallels.c b/block/parallels.c
> index a229c06f25..5fc726f446 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -165,8 +165,9 @@ static int64_t block_status(BDRVParallelsState *s, int64_t sector_num,
>      return start_off;
>  }
>  
> -static int64_t allocate_clusters(BlockDriverState *bs, int64_t sector_num,
> -                                 int nb_sectors, int *pnum)
> +static coroutine_fn int64_t allocate_clusters(BlockDriverState *bs,
> +					      int64_t sector_num,
> +					      int nb_sectors, int *pnum)

Indentation with spaces instead of tabs for QEMU, please.

Kevin

>  {
>      int ret = 0;
>      BDRVParallelsState *s = bs->opaque;
> -- 
> 2.37.3
>
diff mbox series

Patch

diff --git a/block/parallels.c b/block/parallels.c
index a229c06f25..5fc726f446 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -165,8 +165,9 @@  static int64_t block_status(BDRVParallelsState *s, int64_t sector_num,
     return start_off;
 }
 
-static int64_t allocate_clusters(BlockDriverState *bs, int64_t sector_num,
-                                 int nb_sectors, int *pnum)
+static coroutine_fn int64_t allocate_clusters(BlockDriverState *bs,
+					      int64_t sector_num,
+					      int nb_sectors, int *pnum)
 {
     int ret = 0;
     BDRVParallelsState *s = bs->opaque;