diff mbox series

[6/7] linux-user/hppa: Allow PROT_GROWSUP and PROT_GROWSDOWN in mprotect()

Message ID 20220924114501.21767-7-deller@gmx.de (mailing list archive)
State New, archived
Headers show
Series linux-user fixes for hppa target - part 2 | expand

Commit Message

Helge Deller Sept. 24, 2022, 11:45 a.m. UTC 
The hppa platform uses an upwards-growing stack and required in Linux
kernels < 5.18 an executable stack for signal processing.  For that some
executables and libraries are marked to have an executable stack, for
which glibc uses the mprotect() syscall to mark the stack like this:
 mprotect(xfa000000,4096,PROT_EXEC|PROT_READ|PROT_WRITE|PROT_GROWSUP).

Currently qemu will return -TARGET_EINVAL for this syscall because of the
checks in validate_prot_to_pageflags(), which doesn't allow the
PROT_GROWSUP or PROT_GROWSDOWN flags and thus triggers this error in the
guest:
 error while loading shared libraries: libc.so.6: cannot enable executable stack as shared object requires: Invalid argument

Allow mprotect() to handle both flags and thus fix the guest.
The glibc tst-execstack testcase can be used to reproduce the issue.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/mmap.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.37.3
diff mbox series

Patch

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index dba6823668..b7478ad0fa 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -105,6 +105,8 @@  static int validate_prot_to_pageflags(int *host_prot, int prot)
             page_flags |= PAGE_MTE;
         }
     }
+#elif TARGET_HPPA
+    valid |= PROT_GROWSDOWN | PROT_GROWSUP;
 #endif

     return prot & ~valid ? 0 : page_flags;