diff mbox series

[PULL,27/38] target/ppc: Fix xvcmp* clearing FI bit

Message ID	20221017192009.92404-28-danielhb413@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Daniel Henrique Barboza <danielhb413@gmail.com> To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, stefanha@redhat.com, =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>, Richard Henderson <richard.henderson@linaro.org>, Daniel Henrique Barboza <danielhb413@gmail.com> Subject: [PULL 27/38] target/ppc: Fix xvcmp* clearing FI bit Date: Mon, 17 Oct 2022 16:19:58 -0300 Message-Id: <20221017192009.92404-28-danielhb413@gmail.com> In-Reply-To: <20221017192009.92404-1-danielhb413@gmail.com> References: <20221017192009.92404-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>
Series	[PULL,01/38] MAINTAINERS: step back from PPC \| expand [PULL,01/38] MAINTAINERS: step back from PPC [PULL,02/38] target/ppc: restore powerpc_excp_booke doorbell interrupts [PULL,03/38] ppc440_bamboo: Remove unnecessary memsets [PULL,04/38] ppc4xx: Introduce Ppc4xxSdramBank struct [PULL,05/38] ppc4xx_sdram: Get rid of the init RAM hack [PULL,06/38] ppc4xx: Use Ppc4xxSdramBank in ppc4xx_sdram_banks() [PULL,07/38] ppc440_bamboo: Add missing 4 MiB valid memory size [PULL,08/38] ppc4xx_sdram: Move size check to ppc4xx_sdram_init() [PULL,09/38] ppc4xx_sdram: QOM'ify [PULL,10/38] ppc4xx_sdram: Drop extra zeros for readability [PULL,11/38] ppc440_sdram: Split off map/unmap of sdram banks for later reuse [PULL,12/38] ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller [PULL,13/38] ppc440_sdram: Get rid of the init RAM hack [PULL,14/38] ppc440_sdram: Rename local variable for readability [PULL,15/38] ppc4xx_sdram: Rename functions to prevent name clashes [PULL,16/38] ppc440_sdram: Move RAM size check to ppc440_sdram_init [PULL,17/38] ppc440_sdram: QOM'ify [PULL,18/38] ppc440_uc.c: Move some macros to ppc4xx.h [PULL,19/38] ppc440_uc.c: Remove unneeded parenthesis [PULL,20/38] hw/ppc/meson: Allow e500 boards to be enabled separately [PULL,21/38] hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx [PULL,22/38] docs/system/ppc/ppce500: Add heading for networking chapter [PULL,23/38] hw/ppc/e500: Reduce usage of sysbus API [PULL,24/38] hw/ppc/mpc8544ds: Rename wrongly named method [PULL,25/38] hw/ppc/mpc8544ds: Add platform bus [PULL,26/38] hw/ppc/e500: Remove if statement which is now always true [PULL,27/38] target/ppc: Fix xvcmp* clearing FI bit [PULL,28/38] hw/ppc/spapr_pci.c: Use device_cold_reset() rather than device_legacy_reset() [PULL,29/38] qmp/hmp, device_tree.c: introduce dumpdtb [PULL,30/38] hw/nios2: set machine->fdt in nios2_load_dtb() [PULL,31/38] hw/ppc: set machine->fdt in bamboo_load_device_tree() [PULL,32/38] hw/ppc: set machine->fdt in sam460ex_load_device_tree() [PULL,33/38] hw/ppc: set machine->fdt in xilinx_load_device_tree() [PULL,34/38] hw/ppc: set machine->fdt in pegasos2_machine_reset() [PULL,35/38] hw/ppc: set machine->fdt in pnv_reset() [PULL,36/38] hw/ppc: set machine->fdt in spapr machine [PULL,37/38] hw/riscv: set machine->fdt in sifive_u_machine_init() [PULL,38/38] hw/riscv: set machine->fdt in spike_board_init()

Commit Message

Daniel Henrique Barboza Oct. 17, 2022, 7:19 p.m. UTC

From: Víctor Colombo <victor.colombo@eldorado.org.br>

Vector instructions in general are not supposed to change the FI bit.
However, xvcmp* instructions are calling gen_helper_float_check_status,
which is leading to a cleared FI flag where it should be kept
unchanged.
As helper_float_check_status only affects inexact, overflow and
underflow, and the xvcmp* instructions don't change these flags, this
issue can be fixed by removing the call to helper_float_check_status.
By doing this, the FI bit in FPSCR will be preserved as expected.

Fixes: 00084a25adf ("target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions")
Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221005121551.27957-1-victor.colombo@eldorado.org.br>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 target/ppc/translate/vsx-impl.c.inc | 1 -
 1 file changed, 1 deletion(-)

diff mbox series

Patch

diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc
index 7acdbceec4..e6e5c45ffd 100644
--- a/target/ppc/translate/vsx-impl.c.inc
+++ b/target/ppc/translate/vsx-impl.c.inc
@@ -810,7 +810,6 @@  static void gen_##name(DisasContext *ctx)                                     \
         gen_helper_##name(ignored, cpu_env, xt, xa, xb);                      \
         tcg_temp_free_i32(ignored);                                           \
     }                                                                         \
-    gen_helper_float_check_status(cpu_env);                                   \
     tcg_temp_free_ptr(xt);                                                    \
     tcg_temp_free_ptr(xa);                                                    \
     tcg_temp_free_ptr(xb);                                                    \