[v12,08/17] net: stream: Don't ignore EINVAL on netdev socket connection

Commit Message

Laurent Vivier Oct. 20, 2022, 9:16 a.m. UTC

From: Stefano Brivio <[e-mail]>

Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <[e-mail]>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <[e-mail]>
Reviewed-by: Daniel P. Berrangé <[e-mail]>
Reviewed-by: David Gibson <[e-mail]>
Acked-by: Michael S. Tsirkin <[e-mail]>
---
 net/stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/net/stream.c b/net/stream.c
index 0a7e84749a3f..e4388fe7e45c 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -360,8 +360,7 @@  static int net_stream_client_init(NetClientState *peer,
                 if (errno == EINTR || errno == EWOULDBLOCK) {
                     /* continue */
                 } else if (errno == EINPROGRESS ||
-                           errno == EALREADY ||
-                           errno == EINVAL) {
+                           errno == EALREADY) {
                     break;
                 } else {
                     error_setg_errno(errp, errno, "can't connect socket");